Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rate_runner #456

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

alwayslove2013
Copy link
Collaborator

Background:

  • The rate_runner creates a thread pool within a single process to handle submit_by_rate.
  • In contrast, the read_write_runner spawns multiple processes (equal to concurrency) for search tests.

==> It imposes significant scheduling pressure on the vdbbench machine. As a result, submit_by_rate often takes longer than 1s to complete.

In this PR:

  • Increased the warning threshold for submit_by_rate.
  • Modified check_and_send_signal to avoid waiting.
  • By the way, suppressed warning logs for minor task insertions to reduce unnecessary noise.

Signed-off-by: min.tian <[email protected]>
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alwayslove2013, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@XuanYang-cn XuanYang-cn merged commit 78d6906 into zilliztech:vdbbench_1.0 Jan 22, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants