Clean code

setup.py

@@ -9,11 +9,13 @@
 # This source code is licensed under the Apache-2.0 license found in the
 # LICENSE file in the root directory of this source tree.
 
+
 import os
 import sys
 import shutil
 import setuptools
 
+
 # ------------------Package Meta-Data------------------
 PACKAGE_INFO = {}
 

ynmt/binaries/default/preprocess.py

@@ -10,15 +10,12 @@
 # LICENSE file in the root directory of this source tree.
 
 
-import os
-import collections
-
 import ynmt.hocon.arguments as harg
 
 from ynmt.tasks import build_task
 
 from ynmt.utilities.random import fix_random_procedure
-from ynmt.utilities.logging import setup_logger, get_logger, logging_level
+from ynmt.utilities.logging import setup_logger, logging_level
 
 
 def preprocess(args):

ynmt/binaries/default/test.py

@@ -9,10 +9,9 @@
 # This source code is licensed under the Apache-2.0 license found in the
 # LICENSE file in the root directory of this source tree.
 
+
 import os
 import torch
-import importlib
-import pickle
 
 import ynmt.hocon.arguments as harg
 

ynmt/binaries/default/train.py

@@ -10,10 +10,7 @@
 # LICENSE file in the root directory of this source tree.
 
 
-import os
 import torch
-import importlib
-import pickle
 
 import ynmt.hocon.arguments as harg
 

ynmt/criterions/__init__.py

@@ -16,6 +16,7 @@
 
 from ynmt.utilities.registration import Registration, import_modules
 
+
 criterion_registration = Registration(Criterion)
 
 

ynmt/criterions/criterion.py

@@ -12,7 +12,6 @@
 
 import torch
 
-
 from ynmt.utilities.statistics import Statistics
 
 

ynmt/criterions/cross_entropy.py

@@ -12,7 +12,6 @@
 
 import torch
 
-
 from ynmt.criterions import register_criterion, Criterion
 
 

ynmt/criterions/label_smoothing_cross_entropy.py

@@ -12,7 +12,6 @@
 
 import torch
 
-
 from ynmt.criterions import register_criterion, Criterion
 
 

ynmt/data/batch.py

@@ -10,9 +10,6 @@
 # LICENSE file in the root directory of this source tree.
 
 
-import torch
-
-
 class Batch(object):
     def __init__(self, structure, instances=list()):
         assert isinstance(structure, set), 'Type of structure should be set().'

ynmt/data/iterator.py

@@ -13,10 +13,9 @@
 import random
 
 from ynmt.data.batch import Batch
-from ynmt.data.instance import Instance, InstanceComparator
+from ynmt.data.instance import InstanceComparator
 from ynmt.utilities.file import load_datas
 from ynmt.utilities.random import shuffled
-from ynmt.utilities.statistics import Statistics
 
 
 class Iterator(object):

ynmt/hocon/arguments.py

@@ -15,7 +15,6 @@
 import argparse
 import collections
 
-
 from ynmt.utilities.constant import Constant
 
 

ynmt/models/__init__.py

@@ -16,6 +16,7 @@
 
 from ynmt.utilities.registration import Registration, import_modules
 
+
 model_registration = Registration(Model)
 
 

ynmt/modules/decoders/transformer_decoder.py

@@ -13,7 +13,6 @@
 import math
 import torch
 
-
 from ynmt.modules.embeddings import TrigonometricPositionalEmbedding
 from ynmt.modules.attentions import MultiHeadAttention
 from ynmt.modules.perceptrons import PositionWiseFeedForward

ynmt/modules/embeddings/learned_positional_embedding.py

@@ -10,7 +10,6 @@
 # LICENSE file in the root directory of this source tree.
 
 
-import math
 import torch
 
 

ynmt/modules/encoders/transformer_encoder.py

@@ -13,7 +13,6 @@
 import math
 import torch
 
-
 from ynmt.modules.embeddings import TrigonometricPositionalEmbedding
 from ynmt.modules.attentions import MultiHeadAttention
 from ynmt.modules.perceptrons import PositionWiseFeedForward

ynmt/schedulers/__init__.py

@@ -16,6 +16,7 @@
 
 from ynmt.utilities.registration import Registration, import_modules
 
+
 scheduler_registration = Registration(Scheduler)
 
 

ynmt/tasks/mixins/seq.py

@@ -12,7 +12,6 @@
 
 import collections
 
-
 from ynmt.utilities.file import load_plain
 from ynmt.utilities.multiprocessing import multi_process
 

ynmt/tasks/task.py

@@ -12,7 +12,7 @@
 
 from ynmt.data.dataset import Dataset
 
-from ynmt.utilities.file import mk_temp, rm_temp, load_data, load_datas, dump_data, dump_datas
+from ynmt.utilities.file import mk_temp, rm_temp, load_data, dump_data, dump_datas
 from ynmt.utilities.multiprocessing import multi_process
 
 

ynmt/testers/seq2seq.py

@@ -10,8 +10,6 @@
 # LICENSE file in the root directory of this source tree.
 
 
-import os
-import re
 import torch
 
 from ynmt.testers import register_tester, Tester

ynmt/testers/tester.py

@@ -10,7 +10,6 @@
 # LICENSE file in the root directory of this source tree.
 
 
-import re
 import torch
 
 from ynmt.utilities.timer import Timer

ynmt/trainers/trainer.py

@@ -10,12 +10,10 @@
 # LICENSE file in the root directory of this source tree.
 
 
-import re
 import torch
 
-
 from ynmt.utilities.timer import Timer
-from ynmt.utilities.statistics import Statistics, perplexity
+from ynmt.utilities.statistics import Statistics
 from ynmt.utilities.checkpoint import save_checkpoint
 from ynmt.utilities.distributed import reduce_all, gather_all
 
@@ -133,7 +131,9 @@ def launch(self, accumulated_train_batches, accumulated_valid_batches):
             if self.step % self.training_period == 0:
                 self.save()
 
-        self.save()
+        if self.step % self.training_period != 0:
+            self.save()
+
         return
 
     def train(self, accumulated_train_batch):

ynmt/utilities/distributed.py

@@ -13,7 +13,6 @@
 import torch
 import threading
 
-
 from ynmt.utilities.file import dumps, loads
 
 

ynmt/utilities/logging.py

@@ -12,7 +12,6 @@
 
 import logging
 
-
 from ynmt.utilities.file import mk_temp
 
 

ynmt/utilities/registration.py

@@ -14,9 +14,6 @@
 import importlib
 
 
-from ynmt.utilities.constant import Constant
-
-
 def import_modules(father, directory):
     file_names = os.listdir(directory)
     for file_name in file_names:

ynmt/utilities/timer.py

@@ -12,7 +12,6 @@
 
 import time
 
-
 from ynmt.utilities.constant import Constant
 
 

ynmt/utilities/tracker.py

@@ -17,7 +17,6 @@
 import inspect
 import datetime
 
-
 from ynmt.utilities.file import get_temp_file_path
 
 

ynmt/utilities/visualizing.py

@@ -14,7 +14,6 @@
 import json
 import visdom
 
-
 from ynmt.utilities.file import mk_temp
 from ynmt.utilities.constant import Constant
 

ynmt_cli/default/preprocess.py

@@ -9,6 +9,7 @@
 # This source code is licensed under the Apache-2.0 license found in the
 # LICENSE file in the root directory of this source tree.
 
+
 from ynmt.binaries.default.preprocess import main
 
 

ynmt_cli/default/test.py

@@ -9,6 +9,7 @@
 # This source code is licensed under the Apache-2.0 license found in the
 # LICENSE file in the root directory of this source tree.
 
+
 from ynmt.binaries.default.test import main
 
 

ynmt_cli/default/train.py

@@ -9,6 +9,7 @@
 # This source code is licensed under the Apache-2.0 license found in the
 # LICENSE file in the root directory of this source tree.
 
+
 from ynmt.binaries.default.train import main