program: add pause deposit state and guard in deposit & deposit_spl_token #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brewmaster012
requested review from
lumtis,
fbac and
ws4charlie
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14 +/- ##
========================================
- Coverage 9.42% 9.17% -0.25%
========================================
Files 1 1
Lines 191 218 +27
========================================
+ Hits 18 20 +2
- Misses 173 198 +25 ☔ View full report in Codecov by Sentry. |
lumtis
reviewed
Aug 15, 2024
ws4charlie
reviewed
Aug 15, 2024
| pub fn deposit(ctx: Context<Deposit>, amount: u64, memo: Vec<u8>) -> Result<()> { | ||
| require!(memo.len() >= 20, Errors::MemoLengthTooShort); | ||
| require!(memo.len() <= 512, Errors::MemoLengthExceeded); | ||
|
|
||
| let pda = &mut ctx.accounts.pda; |
There was a problem hiding this comment.
not relating to this PR. Could we also print informative logs in withdraw, deposit_spl_token and withdraw_spl_token, similar to the log print in withdraw, which looks so useful (especial to non-technical user). The log seems free of charge in Solana?
ws4charlie
approved these changes
Aug 15, 2024
Co-authored-by: Lucas Bertrand <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that the program can be paused when zeta blockchain is undergoing upgrade or downtime, or TSS migration.
Only user deposits are paused to prevent users losing or experiencing delay in their assets during downtime;
Withdraws are not paused because:
The new guards and instructions are part of the test suite; to run