Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android build fixes for Linux and MacOS #114

Closed
wants to merge 9 commits into from
Closed

Android build fixes for Linux and MacOS #114

wants to merge 9 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Apr 14, 2021 •
edited by ghost
Loading

@joseph-henry
Copy link
Contributor

Thank you for your PR. It is greatly appreciated. However, there are a couple of reasons why this cannot be accepted in its current form:

  • Significant breaking API changes (on my end)
  • Incorrect usage of ZeroTierOne's JNI wrapper (this PR)

I will examine this to see if there is anything I can use to improve the android build situation. But, perhaps your expertise could be of use here: #119 ?

Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

#define ZTS_MAX_NETWORK_ROUTES 32 appears twice in ZeroTierSockets.h
1 participant
@joseph-henry