Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds missing context in logic methods and uses bookstore naming #154

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions docs/zero/bookstore-en.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,15 +23,15 @@ For any point listed above, we need a long article to describe the theory and th

As well, we always adhere to the idea that **prefer tools over conventions and documents**. We hope to reduce the boilerplate code as much as possible, and let developers focus on developing the business related code. For this purpose, we developed the tool `goctl`.

Let’s take the shorturl microservice as a quick example to demonstrate how to quickly create microservices by using [go-zero](https://github.com/zeromicro/go-zero). After finishing this tutorial, you’ll find that it’s so easy to write microservices!
Let’s take the bookstore microservice as a quick example to demonstrate how to quickly create microservices by using [go-zero](https://github.com/zeromicro/go-zero). After finishing this tutorial, you’ll find that it’s so easy to write microservices!

## 1. What is a bookstore service

For simplicity, the bookstore service only contains two functionalities, adding books and quering prices.

Writting this bookstore service is to demonstrate the complete flow of creating a microservice by using go-zero. But algorithms and detail implementations are quite simplified, and this bookstore service is not suitable for production use.

## 2. Architecture of shorturl microservice
## 2. Architecture of bookstore microservice

<img src="../../doc/images/bookstore-arch.png" alt="architecture" width="800" />

Expand Down Expand Up @@ -504,7 +504,7 @@ Till now, we’ve done the modification of API Gateway. All the manually added c
* modify `rpc/add/internal/logic/addlogic.go`, like below:

```go
func (l *AddLogic) Add(in *add.AddReq) (*add.AddResp, error) {
func (l *AddLogic) Add(in *add.AddReq) (l.ctx, *add.AddResp, error) {
// manual code start
_, err := l.svcCtx.Model.Insert(&model.Book{
Book: in.Book,
Expand All @@ -526,7 +526,7 @@ Till now, we’ve done the modification of API Gateway. All the manually added c
```go
func (l *CheckLogic) Check(in *check.CheckReq) (*check.CheckResp, error) {
// manual code start
resp, err := l.svcCtx.Model.FindOne(in.Book)
resp, err := l.svcCtx.Model.FindOne(l.ctx, in.Book)
if err != nil {
return nil, err
}
Expand All @@ -541,7 +541,7 @@ Till now, we’ve done the modification of API Gateway. All the manually added c

till now, we finished modifing the code, all the modified code is marked.

## 11. Call shorten and expand services
## 11. Call add and check services

* call add api

Expand Down