Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: health ok after server start #4544

Closed
wants to merge 1 commit into from
Closed

fix: health ok after server start #4544

wants to merge 1 commit into from

Conversation

zhoushuguang
Copy link
Collaborator

fix #4541

@zhoushuguang zhoushuguang force-pushed the fix/probe-health branch 2 times, most recently from 8464f7a to c4398a9 Compare January 5, 2025 03:58
@zeromicro zeromicro deleted a comment from codecov bot Jan 5, 2025
@kevwan kevwan self-requested a review January 7, 2025 16:54
@kevwan kevwan force-pushed the fix/probe-health branch 2 times, most recently from 74fd13c to 7b6afd1 Compare January 12, 2025 03:21
@kevwan
Copy link
Contributor

kevwan commented Jan 17, 2025

I think the better approach is to change the health check logic that if no probes, return false to indicate NOT ready.

@kevwan
Copy link
Contributor

kevwan commented Jan 22, 2025 •
edited
Loading

Duplicate of #4590

@kevwan kevwan closed this Jan 22, 2025
@kevwan kevwan marked this as a duplicate of #4590 Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevwan kevwan Awaiting requested review from kevwan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ensure Readiness Probe Accuracy for devserver
2 participants
@zhoushuguang @kevwan