Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming some Files #61

Merged

Conversation

InsertCreativityHere
Copy link
Member

This PR renames 3 of the files in the language server:

  • slice_config.rs -> configuration.rs:
    This file holds two structs ServerConfig and SliceConfig. There's no reason for it to be named after only one of them...

  • diagnostic_ext -> diagnostic_handler
    In rust, the ext suffix has a specific meaning: you're using the extension trait pattern to add functionality to a type.
    That isn't what this file does though, it just contains a handful of static helper functions.

  • session -> server_state
    The current name gives the impression that this represents a single session between a client and server,
    but A) we don't even have 'session' semantics, and B) the actual fields it holds are:
    server_config and configuration_sets (which basically hold the data from a compiler run: Ast, diagnostics, etc).
    This sounds like server stuff more than session stuff. Also: we only construct one of these (ever), and it's constructed at server startup.

@InsertCreativityHere InsertCreativityHere merged commit b1761aa into zeroc-ice:main Aug 13, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants