Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames 3 of the files in the language server:
slice_config.rs
->configuration.rs
:This file holds two structs
ServerConfig
andSliceConfig
. There's no reason for it to be named after only one of them...diagnostic_ext
->diagnostic_handler
In rust, the
ext
suffix has a specific meaning: you're using the extension trait pattern to add functionality to a type.That isn't what this file does though, it just contains a handful of static helper functions.
session
->server_state
The current name gives the impression that this represents a single session between a client and server,
but A) we don't even have 'session' semantics, and B) the actual fields it holds are:
server_config
andconfiguration_sets
(which basically hold the data from a compiler run: Ast, diagnostics, etc).This sounds like server stuff more than session stuff. Also: we only construct one of these (ever), and it's constructed at server startup.