[Backport v4.0-branch] drivers: sensor: lis2de12: fix read accel via spi #84515
+9
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The lis2de12 sensor driver spi interface was calling spi read api. This leads to a single byte operation on reading acceleration data which is a multi byte operation. Fix it by adding a call to spi read incr api instead. Added a length check to handle both single and multi byte read properly. Signed-off-by: Mayank Narang <[email protected]> (cherry picked from commit 7b062f5)
Added a length check in the spi write incr routine to handle both single and multi byte write operations properly. Signed-off-by: Mayank Narang <[email protected]> (cherry picked from commit cb60881)
zephyrbot
requested review from
jeppenodgaard,
MaureenHelm,
teburd,
tristan-google,
ubieda and
yperess
ubieda
approved these changes
Jan 24, 2025
jeppenodgaard
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport cb60881~2..cb60881 from #84239.
Fixes #83794