samples: dac: simplify meta data #84480
Open
+17
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hakehuang
force-pushed
the
simplify_dac_sample_meta
branch
from
993a809 to
238bf31
Compare
samples/drivers/dac/Kconfig
Outdated
| ZEPHYR_USER := zephyr,user | ||
|
|
||
| config DAC_SAMPLE_RUN | ||
| bool "Run the application this many seconds" |
There was a problem hiding this comment.
Description doesn't look right.
kartben
reviewed
Jan 24, 2025
samples/drivers/dac/Kconfig
Outdated
| bool "Run the application this many seconds" | ||
| default y if $(dt_node_has_prop,/$(ZEPHYR_USER),dac) | ||
| help | ||
| platfrom supports dac sample. |
hakehuang
force-pushed
the
simplify_dac_sample_meta
branch
from
238bf31 to
9c9fffa
Compare
use config from dts to get the supporting status. remove the platfrom_allow list. Signed-off-by: Hake Huang <[email protected]>
martinjaeger
approved these changes
Jan 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use config from dts to get the supporting status.
remove the platfrom_allow list.