-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drivers: flash: stm32h7 fix RDP #84430
Open
niedzwiecki-dawid
wants to merge
2
commits into
zephyrproject-rtos:main
Choose a base branch
from
niedzwiecki-dawid:drivers_flash_stm32h7_rdp_fix
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
drivers: flash: stm32h7 fix RDP #84430
niedzwiecki-dawid
wants to merge
2
commits into
zephyrproject-rtos:main
from
niedzwiecki-dawid:drivers_flash_stm32h7_rdp_fix
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
de-nordic,
djiatsaf-st,
erwango,
FRASTM,
gautierg-st,
GeorgeCGV,
marwaiehm-st,
mathieuchopstm and
rghaddab
January 23, 2025 11:12
niedzwiecki-dawid
force-pushed
the
drivers_flash_stm32h7_rdp_fix
branch
from
January 23, 2025 11:29
bb02652
to
211b8c1
Compare
niedzwiecki-dawid
force-pushed
the
drivers_flash_stm32h7_rdp_fix
branch
from
January 24, 2025 06:09
211b8c1
to
ae90fd3
Compare
duda-patryk
requested changes
Jan 24, 2025
duda-patryk
requested changes
Jan 24, 2025
duda-patryk
reviewed
Jan 24, 2025
The RDP level is set with the FLASH_OPTSR_PRG register and read with the FLASH_OPTSR_CUR register, not FLASH_OPTCR. Fix that to realy change and read RDP. Signed-off-by: Dawid Niedzwiecki <[email protected]>
Make sure to submit a change of option bytes and wait for the end of the operation. It is done by checking the OPT_BUSY bit. Signed-off-by: Dawid Niedzwiecki <[email protected]>
niedzwiecki-dawid
force-pushed
the
drivers_flash_stm32h7_rdp_fix
branch
from
January 24, 2025 13:42
ae90fd3
to
40b0760
Compare
duda-patryk
approved these changes
Jan 24, 2025
de-nordic
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix RDP EX_OP for STM32H7. It includes: