Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dts: bindings: display: Change the property names in the overlay #83840

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

rruuaanng
Copy link
Collaborator

Unify property names in bindings and overrides, using hyphens (-) instead of underscores (_) as separators.

Copy link
Collaborator

@kartben kartben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is missing a entry in migration guide, you can't just rename properties without documenting it, this will break downstream users.
also commit message should be "drivers: display: ..." imo, the "root" change is in the display bindings, not in shields

@rruuaanng
Copy link
Collaborator Author

this is missing a entry in migration guide, you can't just rename properties without documenting it, this will break downstream users.

also commit message should be "drivers: display: ..." imo, the "root" change is in the display bindings, not in shields

This PR is just a sub-PR of #83352.

@rruuaanng
Copy link
Collaborator Author

Because the commit was too large, I needed to split it. Additionally, I will modify the commit messages later.

@rruuaanng rruuaanng changed the title boards: shields: Change the property names in the overlay dts: bindings: display: Change the property names in the overlay Jan 13, 2025
@zephyrbot zephyrbot added the Release Notes To be mentioned in the release notes label Jan 13, 2025
fabiobaltieri
fabiobaltieri previously approved these changes Jan 13, 2025
kartben
kartben previously approved these changes Jan 13, 2025
Unify property names in bindings and overlay, using
hyphens (-) instead of underscores (_) as separators.

Signed-off-by: James Roy <[email protected]>
Rename the pclk_pol and data_cmd-gpios propertys
to pclk-pol and data-cmd-gpios in the devicetree
and bindings of the display subsystem.

Signed-off-by: James Roy <[email protected]>
@rruuaanng rruuaanng dismissed stale reviews from fabiobaltieri and kartben via b53560c January 14, 2025 07:22
@kartben kartben merged commit 0de4cdf into zephyrproject-rtos:main Jan 15, 2025
24 checks passed
@rruuaanng rruuaanng deleted the dts-style-display branch January 15, 2025 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Display area: Shields Shields (add-on boards) Release Notes To be mentioned in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants