Add a argument server to bt rfcomm server.accept #83786
Open
+8
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: Bluetooth Classic
|
I think you need to squash these so that the tree remains bisectable (i.e. it must be possible to cleanly build in between the commits). |
OK. |
lylezhu2012
force-pushed
the
add_a_argument_server_to_bt_rfcomm_server.accept
branch
from
bfbb20f to
38bff67
Compare
|
Please fix the commit message it now just contains a concatenation of the three previous commit messages, including three signed-off-by lines, which doesn't make sense. |
In current implementation, the `accept` cannot be identified if the same one `accept` callback is passed by the upper layer. Similar with `accept` of `bt_l2cap_server.accept`, add a parameter `server` to the `bt_rfcomm_server.accept` callback. Add a argument `server` to function bt_hfp_hf_accept() to avoid building issue for HFP_HF. Add a argument `server` to function rfcomm_accept() to avoid building issue for shell/rfcomm.c. Signed-off-by: Lyle Zhu <[email protected]>
lylezhu2012
force-pushed
the
add_a_argument_server_to_bt_rfcomm_server.accept
branch
from
38bff67 to
7891cb7
Compare
Yes. Updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
servertobt_rfcomm_server.acceptIn current implementation, the
acceptcannot be identified if the same oneacceptcallback is passed by the upper layer.Similar with
acceptofbt_l2cap_server.accept, add a parameterserverto thebt_rfcomm_server.acceptcallback.