Bluetooth: rfcomm: Support dynamic channel allocation #83785
Conversation
zephyrbot
added
area: Bluetooth
area: Bluetooth Classic
| } else { | ||
| /* Check if given channel is already in use */ | ||
| if (rfcomm_server_lookup_channel(server->channel)) { | ||
| LOG_DBG("Channel already registered"); |
There was a problem hiding this comment.
I keep the code block without any changes. I do not notice this.
I think it can be changed to LOG_WRN.
lylezhu2012
force-pushed
the
rfcomm_support_dynamic_channel_allocation
branch
from
22d63bd to
b58abe9
Compare
| for (; chan <= RFCOMM_CHANNEL_END; chan++) { | ||
| /* Check if given channel is already in use */ | ||
| if (!rfcomm_server_lookup_channel(chan)) { | ||
| server->channel = chan; | ||
| LOG_DBG("Allocated channel 0x%02x for new server", chan); | ||
| break; | ||
| } | ||
| } |
There was a problem hiding this comment.
Do you need to add one lock to avoid that the same channel is allocated to two servers because higher priority task may preempt after the if.
There was a problem hiding this comment.
This is the style of the Bleutooth stack. For example, the l2cap psm allocation of BLE does not have such protection. And servers is not protected for each updating.
So I think the case your description is not including in this PR.
There was a problem hiding this comment.
OK. Maybe it can be improved later.
| @@ -199,15 +199,32 @@ rfcomm_sessions_lookup_bt_conn(struct bt_conn *conn) | |||
|
|
|||
| int bt_rfcomm_server_register(struct bt_rfcomm_server *server) | |||
| { | |||
| if (server->channel < RFCOMM_CHANNEL_START || | |||
There was a problem hiding this comment.
`RFCOMM_CHANNEL_START' definition can be removed?
There was a problem hiding this comment.
It is used to support the dynamic channel allocation if the passed channel is zero.
In the function `bt_rfcomm_server_register()`, the channel cannot be dynamic allocated. And only pre-set channel is supported. Improve the function `bt_rfcomm_server_register()` to support the dynamic channel allocation if the passed channel is zero. Signed-off-by: Lyle Zhu <[email protected]>
lylezhu2012
force-pushed
the
rfcomm_support_dynamic_channel_allocation
branch
from
b58abe9 to
fa87918
Compare
In the function
bt_rfcomm_server_register(), the channel cannot be dynamic allocated. And only pre-set channel is supported.Improve the function
bt_rfcomm_server_register()to support the dynamic channel allocation if the passed channel is zero.