tests: Bluetooth: Audio: Use ext adv for all connectable adv #83761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thalley
force-pushed
the
audio_bsim_ext_adv
branch
3 times, most recently
from
bb48f42 to
d2209af
Compare
Most specs require the use of extended advertising, and most tests used legacy advertising. Implement a common function to create and start an extended advertising set to reduce code duplication. Signed-off-by: Emil Gydesen <[email protected]>
Thalley
force-pushed
the
audio_bsim_ext_adv
branch
from
d2209af to
9113dd6
Compare
Instead of using rs=1,2,3 and 4 we make it 10, 20, 30, 40 as the other values could cause some connection issues. Signed-off-by: Emil Gydesen <[email protected]>
zephyrbot
added
platform: nRF BSIM
zephyrbot
requested review from
aescolar,
asbjornsabo,
babrsn,
Casper-Bonde-Bose,
fredrikdanebjer,
jhedberg,
jthm-ot,
larsgk,
MariuszSkamra,
niym-ot,
pin-zephyr and
sjanc
aescolar
approved these changes
Jan 14, 2025
| @@ -18,19 +18,19 @@ SIMULATION_ID="csip" | |||
|
|
|||
| Execute ./bs_${BOARD_TS}_tests_bsim_bluetooth_audio_prj_conf \ | |||
| -v=${VERBOSITY_LEVEL} -s=${SIMULATION_ID} -d=0 -testid=csip_set_coordinator \ | |||
| -RealEncryption=1 -rs=1 -D=4 | |||
| -RealEncryption=1 -rs=10 -D=4 | |||
There was a problem hiding this comment.
Is this to avoid some controller issue? or just very unlucky connections timing?
There was a problem hiding this comment.
Yeah. The old values failed to connect any of the peripherals on the nRF53 (but did work on the nRF52). @cvinayak has been made aware of this, but easier to adjust timing than to wait for a potential controller change
larsgk
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most specs require the use of extended advertising, and most tests used legacy advertising.
Implement a common function to create and start an extended advertising set to reduce code duplication.