kernel: idle: introduce idle enter hook #83760
Open
+31
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjarki-andreasen
force-pushed
the
kernel-idle-hooks
branch
5 times, most recently
from
8f8d5e8 to
ed7327a
Compare
bjarki-andreasen
changed the title
To allow for custom SoC idle behavior, introduce hook executed when idle thread is entered, and add the config CONFIG_IDLE_DEFAULT_ROUTINE to allow excluding the current "default" idle routine. This addition introduces no functional change unless the hook is explicitly enabled, and the default routine explicitly disabled. Signed-off-by: Bjarki Arge Andreasen <[email protected]>
bjarki-andreasen
force-pushed
the
kernel-idle-hooks
branch
from
ed7327a to
d902520
Compare
zephyrbot
requested review from
andyross,
ceolin,
cfriedt,
dcpleung,
nashif,
npitre,
peter-mitsis and
TaiJuWu
pdgendt
reviewed
Jan 10, 2025
| * This hook is implemented by the SoC and can be used to perform any | ||
| * SoC-specific idle enter logic. | ||
| */ | ||
| void idle_enter_hook(void); |
There was a problem hiding this comment.
If it's SoC specific, maybe clearer and more consistent is
Suggested change
| void idle_enter_hook(void); | |
| void soc_idle_enter_hook(void); |
gmarull
reviewed
Jan 10, 2025
Comment on lines
+11
to
+13
| config IDLE_DEFAULT_ROUTINE | ||
| bool "Execute idle default routine" | ||
| default y |
There was a problem hiding this comment.
any options executed by the default routine should depend on this option, right? e.g. policy stuff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow for custom SoC idle behavior, introduce hook executed
when idle thread is entered, and add the config
CONFIG_IDLE_DEFAULT_ROUTINE to allow excluding the current
"default" idle routine.
This addition introduces no functional change unless the hook
is explicitly enabled, and the default routine explicitly
disabled.