Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Refactor edtlib module code style #83688

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rruuaanng
Copy link
Collaborator

Move the content of the if statement block to
the next line, rather than keeping it on the
same line as the if statement.

Move the content of the if statement block to
the next line, rather than keeping it on the
same line as the if statement.

Signed-off-by: James Roy <[email protected]>
@rruuaanng rruuaanng requested a review from pdgendt January 8, 2025 14:06
@pdgendt
Copy link
Collaborator

pdgendt commented Jan 8, 2025

Looks good, might be worth to combine some of these fixes into 1 PR.

@rruuaanng
Copy link
Collaborator Author

Yes, So, next PR, I will put the changes together. Repeated opening of PR makes me a little tired.

@pdgendt
Copy link
Collaborator

pdgendt commented Jan 8, 2025

Yes, So, next PR, I will put the changes together. Repeated opening of PR makes me a little tired.

Why not append commits to this PR and update the title?

@rruuaanng
Copy link
Collaborator Author

Yes, So, next PR, I will put the changes together. Repeated opening of PR makes me a little tired.

Why not append commits to this PR and update the title?

I was changing the title name, I almost forgot, this is kind of stupid :(

@rruuaanng rruuaanng changed the title style: edtlib: Align if statement blocks to the nextline style: Refactor edtlib module code style Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants