Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

console: winstream: fix conditional #83687

Merged
merged 1 commit into from
Jan 8, 2025
Merged

console: winstream: fix conditional #83687

merged 1 commit into from
Jan 8, 2025

Conversation

nashif
Copy link
Member

@nashif nashif commented Jan 8, 2025 •
edited
Loading

should be CONFIG_SOC_FAMILY_INTEL_ADSP and not SOC_FAMILY_INTEL_ADSP.

Fixes #83636

Signed-off-by: Anas Nashif [email protected]

@nashif
console: winstream: fix conditional
1c77795 
should be CONFIG_SOC_FAMILY_INTEL_ADSP and not SOC_FAMILY_INTEL_ADSP.

Partially fixes zephyrproject-rtos#83636

Signed-off-by: Anas Nashif <[email protected]>
@nashif nashif requested review from andyross and kv2019i January 8, 2025 14:04
@nashif
Copy link
Member Author

nashif commented Jan 8, 2025 •
edited
Loading 

soc/intel/intel_adsp/common/include/adsp-vectors.h:#ifndef SOC_SERIES_INTEL_ADSP_ACE
soc/mediatek/mt8xxx/mbox.c:#ifdef SOC_SERIES_MT8195```

few more of this sort that need fixing...

@nashif nashif added the Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc. label Jan 8, 2025
andyross
andyross approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@andyross andyross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops :)

@kartben kartben merged commit 57b8b05 into zephyrproject-rtos:main Jan 8, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyross andyross andyross approved these changes

@kartben kartben kartben approved these changes

@kv2019i kv2019i Awaiting requested review from kv2019i

Assignees
No one assigned
Labels
area: Console Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cavstool: intel_adsp: load fw error. ZeroDivisionError.
4 participants
@nashif @kartben @andyross @zephyrbot