net: ethernet: Set the ptype by the caller in send #83228
Conversation
| @@ -270,6 +270,9 @@ static inline struct net_pkt *arp_prepare(struct net_if *iface, | |||
| return NULL; | |||
| } | |||
|
|
|||
| net_pkt_set_ll_proto_type(pkt, NET_ETH_PTYPE_ARP); | |||
There was a problem hiding this comment.
In ARP context, arp_gratuitous_send() needs an update too.
Yes, absolutely. There needs to be a cleanup before this is ready for merge. This is currently a draft so people could try it without it getting merged accidentally. |
jukkar
force-pushed
the
devel/l2-send-refactoring
branch
from
80dbfd8 to
ff75c8a
Compare
|
jukkar
force-pushed
the
devel/l2-send-refactoring
branch
2 times, most recently
from
d6c0a85 to
772623d
Compare
@clamattia I will do a separate PR for cleaning up fields in net_pkt that are not needed any more. |
Instead of setting the upper protocol type in ethernet_send() by checking the protocol type bits, use the ptype that is already set by the caller. This allows new protocol types to be supported and makes the system extensible. Signed-off-by: Jukka Rissanen <[email protected]>
Use the 192.0.2/24 address space reserved for documentation. No functional changes by this commit. Signed-off-by: Jukka Rissanen <[email protected]>
kartben
force-pushed
the
devel/l2-send-refactoring
branch
from
772623d to
a839d07
Compare
|
While testing things, I noticed some issues with this. For example ping does not work to the device. If I am not able to figure out the culprit soon, I will send a revert for this. |
|
The ARP issue I encountered is fixed by #84158 |
Instead of setting the upper protocol type in ethernet_send() by checking the protocol type bits, use the ptype that is already set by the caller. This allows new protocol types to be supported and makes the system extensible