[2.7-branch] ci: update download-artifact & update-artifact actions to v4 #83067
Conversation
nashif
changed the title
nashif
requested review from
stephanosio,
kartben and
cfriedt
and removed request for
galak
There was a problem hiding this comment.
However, this is a major update that includes breaking changes. Artifacts created with versions v3 and below are not compatible with the v4 actions. Uploads and downloads must use the same major actions versions. There are also key differences from previous versions that may require updates to your workflows.
Please also update upload-artifact versions otherwise it looks like we'll be in trouble :) (even if they do seem already out-of-sync in some places, e.g the codecov action, v4 seems to basically and very explicitly be incompatible with artifacts uploaded with older versions)
See my comment above. I would strongly recommend doing it in the same PR as GitHub explicitly says uploads from previous versions of the upload action DON'T work |
v2 & v3 are deprecated and not supported anymore. Signed-off-by: Anas Nashif <[email protected]> Co-authored-by: Benjamin Cabé <[email protected]>
kartben
force-pushed
the
topic/ci/download_artifact_version_v2
branch
from
909195f to
e480d0a
Compare
kartben
changed the title
|
@nashif I wonder if the update can be tested on zephyr-testing first, just in case? |
|
Assuming all of this will work without a hitch ;-) Merge away @nashif |
we can try this if it still fails after merging, there is nothing to lose right now, it is broken anyways. |
v2 is deprecated and not supported anymore.
Signed-off-by: Anas Nashif [email protected]