drivers: stepper: adi: tmc2209 minor fixes #82706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jilaypandya
changed the title
zephyrbot
requested review from
bjarki-andreasen,
dipakgmx,
fabiobaltieri and
faxe1008
jilaypandya
force-pushed
the
fix/tmc2209
branch
from
c1a826c to
d596e65
Compare
jilaypandya
force-pushed
the
fix/tmc2209
branch
2 times, most recently
from
9e95b7b to
478f0c9
Compare
jilaypandya
changed the title
jilaypandya
force-pushed
the
fix/tmc2209
branch
from
478f0c9 to
ac00e2c
Compare
kartben
requested changes
Dec 9, 2024
kartben
previously approved these changes
Dec 9, 2024
faxe1008
previously approved these changes
Dec 9, 2024
fabiobaltieri
requested changes
Dec 9, 2024
Comment on lines
176
to
177
| IF_ENABLED(DT_INST_NODE_HAS_PROP(inst, msx_gpios) \ | ||
| , (.msx_pins = tmc22xx_stepper_msx_pins_##inst)) \ |
There was a problem hiding this comment.
is this clang-format?!
Suggested change
| IF_ENABLED(DT_INST_NODE_HAS_PROP(inst, msx_gpios) \ | |
| , (.msx_pins = tmc22xx_stepper_msx_pins_##inst)) \ | |
| IF_ENABLED(DT_INST_NODE_HAS_PROP(inst, msx_gpios), ( \ | |
| .msx_pins = tmc22xx_stepper_msx_pins_##inst)) \ |
or some variation of that, if it's clang-format consider adding a /* clang-format off */ block
jilaypandya
force-pushed
the
fix/tmc2209
branch
2 times, most recently
from
38a8350 to
8b80118
Compare
Comment on lines
176
to
177
| IF_ENABLED(DT_INST_NODE_HAS_PROP(inst, msx_gpios) \ | ||
| , .msx_pins = tmc22xx_stepper_msx_pins_##inst) \ |
There was a problem hiding this comment.
the space after , ?
Parentheses I have removed
There was a problem hiding this comment.
the comma on the new line all alone, it should go on the previous one, the parenthesis I think you have to put it back, not totally sure about it though, see if it builds, my preferred format would be
IF_ENABLED(DT_INST_NODE_HAS_PROP(inst, msx_gpios), (
.msx_pins = tmc22xx_stepper_msx_pins_##inst,
))
There was a problem hiding this comment.
I would go for a bold:
IF_ENABLED( \
DT_INST_NODE_HAS_PROP(inst, msx_gpios), \
(.msx_pins = tmc22xx_stepper_msx_pins_##inst) \
) \
There was a problem hiding this comment.
yeah as long as there's no stray , dangling around, and I'd suggest keeping the , after ##inst otherwise it'd fail if you add something after it
… msx The current implementation of tmc2209 driver does not allow instantiation of the driver without configuring msx pins. Signed-off-by: Jilay Pandya <[email protected]>
for the brevity renaming direction_gpios to dir_gpios since STEP/DIR interface is quite an established term in context of stepper controllers. Signed-off-by: Jilay Pandya <[email protected]>
jilaypandya
force-pushed
the
fix/tmc2209
branch
from
8b80118 to
6e69d36
Compare
fabiobaltieri
approved these changes
Dec 10, 2024
kartben
approved these changes
Dec 10, 2024
faxe1008
approved these changes
Dec 10, 2024
rruuaanng
approved these changes
Dec 10, 2024
bjarki-andreasen
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of tmc2209 driver does not allow instantiation of the driver without configuring msx pins.
(Found by removing msx_gpios from overlay and then could not compile the driver)
Second Commit renames direction-gpios to dir-gpios since STEP/DIR is a well established term in context of stepper controllers