-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bluetooth: samples: grammatical fixes #82673
Conversation
@baaatli is there a reason for closing/reopening new PRs? Anything we can do to help? |
Hi @kartben Sorry, noobie Zephyrer here :) I am learning to contribute on Zephyr. I missed some of the checks in the last PR I raised. I did not realise the things like ` before the reference links and hence closed the previous PRs to not waste your time reviewing it. I'll make sure to review them better before raising a PR the next time. Apologies for the inconvenience. |
No worries:) |
Hi @baaatli, could you please squash your commits. |
The following west manifest projects have changed revision in this Pull Request:
✅ All manifest checks OK Note: This message is automatically posted and updated by the Manifest GitHub Action. |
@dipakgmx done! ( some mishap in between, sorry :) ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks generally fine to me - just a small whitespace issue I commented on separately inline
Please squash the two commits into a single one |
Fixed some grammatical and spelling mistakes in channel sounding example Signed-off-by: Vardhan Batavia <[email protected]>
revision: 0ea9c65e8e14fe01c055e571ad2e6fe5337dc58d | ||
revision: d291bdcc4a59bace5ae7453e777e06080ccda8ce |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's this? Doesn't seem related to any language fixes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
idk where this stemmed from. I didn't change anything in this file.
I did this to squash commits. Maybe this squashed a different commit.
git fetch git reset --soft HEAD~2 git commit git push -f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is too much effort for you folks to have so many reviews for such a small change. I will close this PR, raise a new one in draft mode and make sure it passes the pipeline before raising it for your review. Thanks for your time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can drop that commit and then the PR is good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@baaatli when you have just a single commit, you can update it simply using git commit --amend
. You can always check the content what you're about to push using e.g. git show
(for just a single commit) or e.g. git log -p upstream/main..
. Also, no need to close this PR and create a new one. Just fix up your local tree, and once you've verified that everything is fine do another git push --force
.
Fixed some of the grammatical errors and spelling mistakes in the README.rst file.