drivers:sensor:ak09918c use RTIO #82665
Conversation
FlorianWeber1018
force-pushed
the
ak09918_using_rtio
branch
11 times, most recently
from
63e76e6 to
da1ce65
Compare
FlorianWeber1018
force-pushed
the
ak09918_using_rtio
branch
2 times, most recently
from
6b5345a to
e7bac6b
Compare
|
CI is failing because of #82992 |
zephyrbot
requested review from
asemjonovs,
avisconti,
jeppenodgaard,
MaureenHelm,
teburd,
tristan-google,
ubieda and
yperess
| return sqe; | ||
| } | ||
|
|
||
| struct rtio_sqe *i2c_rtio_copy_reg_burst_read(struct rtio *r, struct rtio_iodev *iodev, |
There was a problem hiding this comment.
These are nice little helpers
There was a problem hiding this comment.
If you like those It would be consequent to add also a i2c_rtio_copy_reg_read_byte helper as well, but this is not needed by this driver. If required I can make a separate PR for those helper functions and and add that as well.
| LOG_ERR("Failed to start measurement."); | ||
| return -EIO; | ||
| AKM09918C_CNTL2_SINGLE_MEASURE) == 0) { | ||
| return 0; |
There was a problem hiding this comment.
Why inverse the return codes here? The typical early return path in Zephyr functions is the failure case unless there happens to be a shortcut for a success. Does the CNTL1_PWR_DOWN mode not being set constitute an IO error really?
There was a problem hiding this comment.
Short answer: you are right - I have reverted the change.
I thought that the device is in power down mode could be the only valid mode when trying to trigger a single shot, but thats not correct at all.
From my understanding the device is in continues measurement mode (by setting the SENSOR_ATTR_SAMPLING_FREQUENCY to a valid value) the start_measurement was also called by sample sample_fetch and should just don´t do anything and return 0. That´s not that elegant but not related to this PR.
teburd
dismissed
their stale review
Mean to add comments not approve just yet, oops!
FlorianWeber1018
force-pushed
the
ak09918_using_rtio
branch
from
e7bac6b to
4afdf22
Compare
zephyrbot
removed
manifest-mcuboot
manifest-hal_nxp
manifest-hal_stm32
manifest-lvgl
manifest-nrf_hw_models
manifest-hal_silabs
manifest-sof
manifest-open-amp
manifest-libmetal
manifest-hal_st
manifest-hal_espressif
manifest-nanopb
manifest-segger
manifest-hal_infineon
manifest-hal_ethos_u
manifest-picolibc
manifest-hal_renesas
manifest-liblc3
manifest-hal_intel
manifest-percepio
manifest-hostap
manifest-hal_tdk
manifest-nrf_wifi
manifest-cmsis_6
DNM
include/zephyr/drivers/i2c.h
Outdated
|
|
||
| #endif /* CONFIG_I2C_RTIO */ | ||
|
|
||
| /** |
include/zephyr/drivers/i2c.h
Outdated
| * | ||
| * @return a value from i2c_transfer() | ||
| */ | ||
| static inline int i2c_transfer_dt(const struct i2c_dt_spec *spec, |
|
@MaureenHelm seems like some issue building with adxl345 in CI with this change, which doesn't make much sense, can you take a look? https://github.com/zephyrproject-rtos/zephyr/actions/runs/12695436379/job/35387323768?pr=82665#step:11:2327 |
extend i2c library to create rtio sqes for reading and writing bytes Signed-off-by: Florian Weber <[email protected]>
make usage of the RTIO in the ak09918c driver Signed-off-by: Florian Weber <[email protected]>
FlorianWeber1018
force-pushed
the
ak09918_using_rtio
branch
from
023bb15 to
0603dd4
Compare
make usage of the RTIO in the ak09918c driver.