Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add minimal support for RZ/G3S SMARC (CM33) #82016

Merged
merged 7 commits into from
Dec 12, 2024
Merged

Add minimal support for RZ/G3S SMARC (CM33) #82016

merged 7 commits into from
Dec 12, 2024

Conversation

binhnguyen2434
Copy link
Collaborator

@binhnguyen2434 binhnguyen2434 commented Nov 26, 2024 •
edited by kartben
Loading

  • Add minimal support for RZ/G3S SMARC as following:
Interface Controller Driver/Component
GPIO on-chip gpio
Pinctrl on-chip gpio
UART on-chip serial

Need: zephyrproject-rtos/hal_renesas#50

docs: https://builds.zephyrproject.io/zephyr/pr/82016/docs/boards/renesas/rzg3s_smarc/doc/index.html

@github-actions GitHub Actions
Copy link

Hello @binhnguyen2434, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

@zephyrbot
Copy link
Collaborator

zephyrbot commented Nov 26, 2024 •
edited
Loading

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
hal_renesas zephyrproject-rtos/hal_renesas@f77a850 zephyrproject-rtos/hal_renesas@ca0be9e (main) zephyrproject-rtos/[email protected]

✅ All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@zephyrbot zephyrbot added manifest manifest-hal_renesas DNM This PR should not be merged (Do Not Merge) area: GPIO area: UART Universal Asynchronous Receiver-Transmitter area: Samples Samples platforms: Renesas RZ area: Pinctrl labels Nov 26, 2024
nordicjm
nordicjm requested changes Nov 26, 2024
View reviewed changes
Copy link
Collaborator

@nordicjm nordicjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drivers must correctly select PINCTRL

soc/renesas/rz/rzg3s/Kconfig.soc Show resolved Hide resolved
boards/renesas/rzg3s_smarc/doc/index.rst Outdated Show resolved Hide resolved
boards/renesas/rzg3s_smarc/doc/index.rst Outdated Show resolved Hide resolved
boards/renesas/rzg3s_smarc/doc/index.rst Outdated Show resolved Hide resolved
boards/renesas/rzg3s_smarc/rzg3s_smarc_r9a08g045s33gbg_cm33_defconfig Outdated Show resolved Hide resolved
@nhutnguyenkc nhutnguyenkc force-pushed the rzg3s-support-1.1 branch 2 times, most recently from 9c43ae7 to bb485cf Compare November 26, 2024 11:02
@binhnguyen2434
Copy link
Collaborator Author

Hi @nordicjm, @tejlmand, @kartben
Sorry for bothering, I just rebased onto main to resolve conflict.
Please kindly check and approve again.

tejlmand
tejlmand previously approved these changes Dec 6, 2024
View reviewed changes
kartben
kartben previously approved these changes Dec 6, 2024
View reviewed changes
@kartben kartben assigned tgorochowik and unassigned dcpleung Dec 10, 2024
@kartben
Copy link
Collaborator

kartben commented Dec 10, 2024

@tgorochowik please review.
As a follow-up, it will be nice to update the MAINTAINERS.yml entry for Renesas RZ platform so that it catches all RZ socs/drivers/boards :)

nordicjm
nordicjm previously approved these changes Dec 11, 2024
View reviewed changes
nhutnguyenkc and others added 4 commits December 11, 2024 18:55
@nhutnguyenkc @binhnguyen2434
drivers: pinctrl: Add support for RZ/G3S
3b2afca 
This is the initial commit to support pinctrl driver for Renesas RZ/G3S

Signed-off-by: Quang Le <[email protected]>
Signed-off-by: Nhut Nguyen <[email protected]>
@nhutnguyenkc @binhnguyen2434
drivers: serial: Add polling mode support for RZ/G3S
b20eec9 
This is the initial commit to support UART driver for Renesas RZ/G3S.
The driver only implements polling API for minimal support.

Signed-off-by: Nhut Nguyen <[email protected]>
Signed-off-by: Binh Nguyen <[email protected]>
@nhutnguyenkc @binhnguyen2434
drivers: gpio: Add support for RZ/G3S
f0a05e2 
This adds GPIO driver for Renesas RZ/G3S.

Signed-off-by: Quang Le <[email protected]>
Signed-off-by: Nhut Nguyen <[email protected]>
Signed-off-by: Binh Nguyen <[email protected]>
@binhnguyen2434
tests: lib: cpp: cxx: Exclude Renesas RZ in cpp98
654f4fb 
Exclude Renesas RZ in cpp98 as Renesas HALs are not
compatible with C++98.

Signed-off-by: Binh Nguyen <[email protected]>
@binhnguyen2434 binhnguyen2434 dismissed stale reviews from nordicjm, kartben, and tejlmand via 654f4fb December 11, 2024 11:56
@KhiemNguyenT KhiemNguyenT self-requested a review December 12, 2024 07:41
KhiemNguyenT
KhiemNguyenT approved these changes Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@KhiemNguyenT KhiemNguyenT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Please continue adding more support for other peripherals.

@kartben kartben merged commit 6dc611a into zephyrproject-rtos:main Dec 12, 2024
27 checks passed
@github-actions GitHub Actions
Copy link

Hi @binhnguyen2434!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

This was referenced Feb 4, 2025
Closed
Open
@binhnguyen2434 binhnguyen2434 deleted the rzg3s-support-1.1 branch February 6, 2025 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kartben kartben kartben approved these changes

@tgorochowik tgorochowik tgorochowik approved these changes

@KhiemNguyenT KhiemNguyenT KhiemNguyenT approved these changes

@thaoluonguw thaoluonguw thaoluonguw approved these changes

@tejlmand tejlmand tejlmand left review comments

@nordicjm nordicjm nordicjm left review comments

@dcpleung dcpleung Awaiting requested review from dcpleung

@gmarull gmarull Awaiting requested review from gmarull

@henrikbrixandersen henrikbrixandersen Awaiting requested review from henrikbrixandersen

@mnkp mnkp Awaiting requested review from mnkp

@nashif nashif Awaiting requested review from nashif

@alexanderwachter alexanderwachter Awaiting requested review from alexanderwachter

@cfriedt cfriedt Awaiting requested review from cfriedt

@stephanosio stephanosio Awaiting requested review from stephanosio

Assignees

@tgorochowik tgorochowik

Labels
area: C++ area: GPIO area: Pinctrl area: Samples Samples area: UART Universal Asynchronous Receiver-Transmitter manifest manifest-hal_renesas platforms: Renesas RZ
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@binhnguyen2434 @zephyrbot @kartben @tgorochowik @tejlmand @KhiemNguyenT @nordicjm @thaoluonguw @dcpleung @nhutnguyenkc