Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers: wifi: nxp: add Wi-Fi thread configurations #81693

Merged

Conversation

MaochenWang1
Copy link
Collaborator

Support configuring Wi-Fi threads stack size and priority through Kconfig.

jukkar
jukkar previously approved these changes Nov 21, 2024
@danieldegrasse
Copy link
Collaborator

After some internal discussion, I think it makes sense for us to hold off on merging this for now. The actual code changes to use these Kconfigs still need to be sent to the NXP HAL upstream, and I think it would be best to send these changes with that update, so the Kconfigs can actually be validated by a build.

@jukkar jukkar added the DNM This PR should not be merged (Do Not Merge) label Nov 26, 2024
@jukkar
Copy link
Member

jukkar commented Nov 26, 2024

I think it makes sense for us to hold off on merging this for now.

Ok, I added DNM label for this PR, please remove it after this is ready.

@zephyrbot
Copy link
Collaborator

zephyrbot commented Nov 27, 2024

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
hal_nxp zephyrproject-rtos/hal_nxp@d291bdc zephyrproject-rtos/hal_nxp@97855e4 (master) zephyrproject-rtos/[email protected]

All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@MaochenWang1
Copy link
Collaborator Author

After some internal discussion, I think it makes sense for us to hold off on merging this for now. The actual code changes to use these Kconfigs still need to be sent to the NXP HAL upstream, and I think it would be best to send these changes with that update, so the Kconfigs can actually be validated by a build.

Hi @danieldegrasse the related hal_nxp upstream change, please review:
zephyrproject-rtos/hal_nxp#479

danieldegrasse
danieldegrasse previously approved these changes Dec 3, 2024
danieldegrasse
danieldegrasse previously approved these changes Dec 6, 2024
jukkar
jukkar previously approved these changes Dec 9, 2024
@dleach02 dleach02 dismissed stale reviews from jukkar and danieldegrasse via c0ea249 December 9, 2024 15:56
@dleach02 dleach02 force-pushed the main_mc_nxp_wifi_thread branch from ac00b49 to c0ea249 Compare December 9, 2024 15:56
@zephyrbot zephyrbot removed the DNM This PR should not be merged (Do Not Merge) label Dec 9, 2024
Support configuring Wi-Fi threads stack size and priority through
Kconfig.

Signed-off-by: Maochen Wang <[email protected]>
jukkar
jukkar previously approved these changes Dec 9, 2024
@dleach02 dleach02 requested a review from jukkar December 9, 2024 16:01
@dleach02 dleach02 merged commit c007ac4 into zephyrproject-rtos:main Dec 10, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants