modules: hal_nordic: nrfx: cleanup #81661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
masz-nordic
commented
Nov 20, 2024
masz-nordic
commented
- Remove copied nrfx_configs, use ones from hal_nordic
- Other cleanups
masz-nordic
force-pushed
the
nrfx_config_cleanup
branch
from
73c3f2c to
36c8932
Compare
|
The following west manifest projects have changed revision in this Pull Request:
✅ All manifest checks OK Note: This message is automatically posted and updated by the Manifest GitHub Action. |
zephyrbot
added
manifest
manifest-hal_nordic
DNM
masz-nordic
force-pushed
the
nrfx_config_cleanup
branch
5 times, most recently
from
ed02436 to
fedac28
Compare
masz-nordic
force-pushed
the
nrfx_config_cleanup
branch
7 times, most recently
from
4538da3 to
1453f38
Compare
zephyrbot
added
platform: nRF
zephyrbot
requested review from
carlescufi,
cvinayak,
erbr-ot,
hubertmis,
krish2718 and
kruithofa
bjarki-andreasen
previously approved these changes
Jan 8, 2025
nika-nordic
previously approved these changes
Jan 8, 2025
masz-nordic
dismissed stale reviews from nika-nordic and bjarki-andreasen
via
3a3d3ad
masz-nordic
force-pushed
the
nrfx_config_cleanup
branch
2 times, most recently
from
3a3d3ad to
0013ae0
Compare
gmarull
previously approved these changes
Jan 9, 2025
bjarki-andreasen
previously approved these changes
Jan 9, 2025
nika-nordic
previously approved these changes
Jan 9, 2025
masz-nordic
dismissed stale reviews from nika-nordic, bjarki-andreasen, and gmarull
via
5b65ffc
masz-nordic
force-pushed
the
nrfx_config_cleanup
branch
from
0013ae0 to
5b65ffc
Compare
bjarki-andreasen
previously approved these changes
Jan 9, 2025
gmarull
previously approved these changes
Jan 10, 2025
anangl
reviewed
Jan 10, 2025
masz-nordic
dismissed stale reviews from gmarull and bjarki-andreasen
via
a6fa8e7
masz-nordic
force-pushed
the
nrfx_config_cleanup
branch
from
5b65ffc to
a6fa8e7
Compare
anangl
approved these changes
Jan 13, 2025
bjarki-andreasen
approved these changes
Jan 13, 2025
Update with fixes for nrfx_config cleanup. Signed-off-by: Marcin Szymczyk <[email protected]>
There is no reason to duplicate `nrfx_config_*.h` files. Use configuration files from `hal_nordic/nrfx/templates`. Signed-off-by: Marcin Szymczyk <[email protected]>
* Move all KConfig configuration from CMake to `nrfx_kconfig.h` * Move macro utils from `nrfx_kconfig.h` to `nrfx_zephyr_utils.h` * Move GRTC channels allocation from `nrfx_kconfig.h` to `nrfx_reserved_resources.h` Signed-off-by: Marcin Szymczyk <[email protected]>
masz-nordic
force-pushed
the
nrfx_config_cleanup
branch
from
a6fa8e7 to
534916c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.