Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support ospi driver for Renesas RA8 devices #80799

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add support ospi driver for Renesas RA8 devices #80799

wants to merge 5 commits into from

Conversation

thaoluonguw
Copy link
Collaborator

Add support for ospi driver running on Renesas RA8 (RA8M1 and RA8D1)

  • boards: renesas: Add support for ospi on ek_ra8m1 and ek_ra8d1
  • drivers: flash: Add support for ospi_b driver
  • dts: arm: Add support for ospi
  • dts: bindings: Add support for ospi_b
  • tests: drivers: flash: common: Add support for ospi.
  • samples: drivers: jesd216: Add support for ospi
  • samples: drivers: spi_flash: Add support for ospi

Note: This PR requires #79766 is merged

@zephyrbot
Copy link
Collaborator

zephyrbot commented Nov 3, 2024 •
edited
Loading

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff

✅ All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@zephyrbot zephyrbot added manifest manifest-hal_renesas DNM This PR should not be merged (Do Not Merge) labels Nov 3, 2024
@quytranpzz quytranpzz force-pushed the support_renesas_ra8_ospi branch from 8f49aa6 to ae8e589 Compare November 29, 2024 03:55
@thaoluonguw thaoluonguw marked this pull request as ready for review November 30, 2024 06:13
@zephyrbot zephyrbot added area: Flash platform: Renesas RA Renesas Electronics Corporation, RA area: Samples Samples labels Nov 30, 2024
@quytranpzz quytranpzz force-pushed the support_renesas_ra8_ospi branch from ae8e589 to a585f29 Compare December 6, 2024 09:26
@zephyrbot zephyrbot removed manifest manifest-hal_renesas DNM This PR should not be merged (Do Not Merge) labels Dec 6, 2024
@thaoluonguw thaoluonguw force-pushed the support_renesas_ra8_ospi branch from a585f29 to 7d172b6 Compare January 6, 2025 13:50
@thaoluonguw
Copy link
Collaborator Author

Rebase with main to solve conflicts.

@thaoluonguw
Copy link
Collaborator Author

Hello @GeorgeCGV : Could you please help us review again? Thank you so much.

@GeorgeCGV
Copy link
Collaborator

GeorgeCGV commented Jan 10, 2025 •
edited
Loading

Hello @GeorgeCGV : Could you please help us review again? Thank you so much.

Hello, great work overall. Unfortunately, I don't have the platform to validate fully. I left some comments and concerns.
Also, the initial value assignment (e.g., err = 0) can be omitted in some places.

@thaoluonguw thaoluonguw force-pushed the support_renesas_ra8_ospi branch from 7d172b6 to 13a8287 Compare January 14, 2025 11:12
Tri Nguyen and others added 5 commits January 20, 2025 00:07
@thaoluonguw
drivers: flash: Initial support OSPI flash driver on RA8 boards
cf05310 
Support OSPI flash driver on EK-RA8M1 and EK-RA8D1 with ospi_b
and S28HL512T flash.

Signed-off-by: Tri Nguyen <[email protected]>
Signed-off-by: Thao Luong <[email protected]>
@quytranpzz @thaoluonguw
dts: renesas: Add devicetree property for OSPI support on RA8
84e49e5 
Add ospi node on Renesas RA8 devicetree to support QSPI flash driver

Signed-off-by: Quy Tran <[email protected]>
@quytranpzz @thaoluonguw
boards: renesas: Add boards support for OSPI flash driver on RA8
09f24ac 
Add support for OSPI flash driver on EK-RA8D1 and EK-RA8M1

Signed-off-by: Quy Tran <[email protected]>
@thaoluonguw
tests: drivers: flash: add ospi driver for RA8
a24fa32 
Add test for ospi driver in RA8 boards

Signed-off-by: Tri Nguyen <[email protected]>
Signed-off-by: Thao Luong <[email protected]>
@thaoluonguw
samples: drivers: Add ospi driver for RA8
8db1905 
Add sample ospi for spi_flash and jesd216

Signed-off-by: Tri Nguyen <[email protected]>
Signed-off-by: Thao Luong <[email protected]>
@thaoluonguw thaoluonguw force-pushed the support_renesas_ra8_ospi branch from 13a8287 to 8db1905 Compare January 19, 2025 17:28
@thaoluonguw
Copy link
Collaborator Author

Hello @GeorgeCGV , I updated as you advice, could you please recheck again? Thank you.

GeorgeCGV
GeorgeCGV approved these changes Jan 21, 2025
View reviewed changes
Copy link
Collaborator

@GeorgeCGV GeorgeCGV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thaoluonguw, thank you for the adaptations. It would be great to factor out the spi_nor.h modification and reformat to a standalone commit.

By the way, are you aware of the #71769 effort? It might have been beneficial to implement the new driver against that API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quytranpzz quytranpzz quytranpzz left review comments

@GeorgeCGV GeorgeCGV GeorgeCGV approved these changes

@soburi soburi Awaiting requested review from soburi

@KhiemNguyenT KhiemNguyenT Awaiting requested review from KhiemNguyenT

@FRASTM FRASTM Awaiting requested review from FRASTM

@duynguyenxa duynguyenxa Awaiting requested review from duynguyenxa

@de-nordic de-nordic Awaiting requested review from de-nordic

@kartben kartben Awaiting requested review from kartben

@nashif nashif Awaiting requested review from nashif

@rghaddab rghaddab Awaiting requested review from rghaddab

At least 2 approving reviews are required to merge this pull request.

Assignees

@de-nordic de-nordic

Labels
area: Flash area: Samples Samples platform: Renesas RA Renesas Electronics Corporation, RA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@thaoluonguw @zephyrbot @GeorgeCGV @quytranpzz @de-nordic