posix: move limit definitions to posix/sys/limits.h #80469
+245
−110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfriedt
force-pushed
the
posix-limits-and-features-rework
branch
from
85c45f0 to
97e71ee
Compare
ycsin
previously approved these changes
Oct 29, 2024
|
@keith-packard can you please take a look? |
|
@cfriedt This will need a rebase |
Rather than defining values that should appear in limits.h in posix_features.h, move them to a separate file. Undefine any externally defined POSIX limits, since Zephyr would prefer to define those based on Kconfig values. Signed-off-by: Chris Friedt <[email protected]>
cfriedt
force-pushed
the
posix-limits-and-features-rework
branch
from
97e71ee to
4362362
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than defining values that should appear in limits.h in posix_features.h, move them to a separate file.
Undefine any externally defined POSIX limits, since Zephyr would prefer to define those based on Kconfig values.
Additionally, convert runtime invariant values to constant if they should be constant.
Fixes #80409
Testing done
Note
Running
clang-formatdoes not produce code that passes compliance checks due to strangeness withCOND_CODE_1(), so some lines are manually formatted (as they had been inposix_features.h).