drivers: i2s: Make the stm32 i2s driver use a msgq #80419
+37
−128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
anangl,
erwango,
FRASTM,
gautierg-st,
GeorgeCGV,
marwaiehm-st and
mathieuchopstm
|
A quite welcome change. Could you mention how you tested it (particularly on which HW) ? Review might be delayed by few weeks due to the on going release, but definitely something we should look into closely. |
cdesjardins
force-pushed
the
stm32_i2s_cleanup
branch
from
c6ec982 to
3cb321c
Compare
|
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
|
@cdesjardins Would you mind fixing reported Coding guidelines and Compliance checks issues. |
cdesjardins
force-pushed
the
stm32_i2s_cleanup
branch
from
3cb321c to
c9fabe3
Compare
cdesjardins
force-pushed
the
stm32_i2s_cleanup
branch
from
c9fabe3 to
12ecca7
Compare
Currently uses a home grown ringbuffer and a semaphore with irq locks. Signed-off-by: Chris Desjardins <[email protected]>
cdesjardins
force-pushed
the
stm32_i2s_cleanup
branch
from
12ecca7 to
a970c76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently uses a home grown ringbuffer and a semaphore with irq locks.
Tested on stm32h7 custom board.