boards: add Myra SiP Baseboard #79706

fkokosinski · 2024-10-11T10:13:43Z

This PR:

~~adds driver for the mb85rsm1t fram~~
adds support for a new SoC in Zephyr - Myra SiP
adds a new target that is based on the Myra SiP - Myra SiP Baseboard

nordicjm · 2024-10-11T10:53:39Z

boards/antmicro/myra_sip_baseboard/doc/img/myra_sip_baseboard.jpg

Convert to webp, then put through https://tinypng.com/

Done, filesize went down from 93k -> 34k

nordicjm · 2024-10-11T10:53:51Z

boards/antmicro/myra_sip_baseboard/doc/index.rst

+Supported Features
+------------------
+
+The Zephyr ``myra_sip_baseboard`` board configuration supports the following hardware features:


*board target

soc/antmicro/myra/Kconfig.soc

nordicjm

More I think about it the more it is a no, this is an stm32 with supporting components, they go in the board dts, do not create a "soc sip", use the existing stm32 one. This is no different than e.g. rm1xx_dvk where there is an spi flash inside the module

kgugala · 2024-10-11T13:09:25Z

Hi @nordicjm, thanks for your comment.

More I think about it the more it is a no, this is an stm32 with supporting components, they go in the board dts, do not create a "soc sip", use the existing stm32 one

This approach would mean that the shared configuration between board targets that share the same SiP would have to include duplicated code that would be otherwise provided by the SiP symbol, though.

Additionally, there already are other SIPs defined in a similar way in Zephyr, e.g.:

soc/nordic/nrf91/Kconfig.soc:
- CONFIG_SOC_NRF9161_LACA
soc/nordic/nrf92/Kconfig.soc:
- CONFIG_SOC_NRF9280
soc/espressif/esp32s2/Kconfig.soc:
- CONFIG_SOC_ESP32S2_SOLO_N* (4 types)
- CONFIG_SOC_ESP32S2_MINI* (2 types)
- CONFIG_SOC_ESP32S2_WROOM
- CONFIG_SOC_ESP32S2_WROVER* (3 types)
soc/espressif/esp32s3/Kconfig.soc:
- CONFIG_SOC_ESP32S3_MINI* (2 types)
- CONFIG_SOC_ESP32S3_WROOM* (9 types)

For now, all the SIPs in supported in Zephyr are produced by the same vendor as the main SoC used in the SIP, however this is not always a case in the real world. Another example (similar to Myra) of such a SIP is https://octavosystems.com/octavo_products/osd32mp15x/ (this one is not yet supported in Zephyr, but we plan to add it soon)

nordicjm · 2024-10-11T13:23:06Z

The 91* and 92* are normal SoCs in tree so I don't see what you mean. The espressif ones are different chips with different internal configurations, this one you have here is just a specific stm32 chip with peripherals around it, there is no reason to do it as you've done it here. Not that SiP's aren't important and support for that in hwmv2 is planned for the future, but there is nothing groundbreaking here that cannot be done as every other "SiP" in zephyr is done with a normal SoC definition for the actual SoC and then anything inside of a "package" being done at board level

fkokosinski · 2024-10-14T14:23:03Z

The 91* and 92* are normal SoCs in tree so I don't see what you mean

Those nRFs mentioned by @kgugala are referred to as SiPs by comments in their respective Kconfigs. As for CONFIG_SOC_NRF9161_LACA, the comment is here: https://github.com/zephyrproject-rtos/zephyr/blob/main/soc/nordic/nrf91/Kconfig.soc#L31-L3

Plus, on the vendor's site nRF9161 is also explicitly called a SiP: https://www.nordicsemi.com/Products/nRF9161.

The nRF9161 is technically a SiP (System-in-Package) that consists of the nRF9120 SoC and additional components like PMIC, FEM, and XTAL, so for nrfx/MDK the nRF9120 SoC is to be indicated as the build target, but since the nRF9161 is what a user can actually see on a board, using only nRF9120 in the Zephyr build infrastructure might be confusing. That's why in the top level of SoC definitions (for user-configurable options in Kconfig, for example) the nRF9161 term is used and nRF9120 underneath.

And as for CONFIG_SOC_NRF9280, the comment is present here: https://github.com/zephyrproject-rtos/zephyr/blob/main/soc/nordic/nrf92/Kconfig.soc#L37

The SiP selects the actual SoC complete with engineer revision and appropriate CPU

Additionally, this file also states the following: https://github.com/zephyrproject-rtos/zephyr/blob/main/soc/nordic/nrf92/Kconfig.soc#L12-L14

Like it's done for the nRF91 family, let the nRF9280 SiP be represented by nRF9280 "SoC" in top-level SoC definitions and user-configurable Kconfigs, since that's what visible to users.

Which means that those nRFs are explicitly defined as SiPs, and are definitely not "normal" SoCs.

The espressif ones are different chips with different internal configurations

Again, those ESPs that Karol had mentioned are listed under the "SiP" section comment in their respective Kconfig files:

SiP with flash and/or psram

but there is nothing groundbreaking here that cannot be done as every other "SiP" in zephyr is done with a normal SoC definition for the actual SoC and then anything inside of a "package" being done at board level

That's not exactly true, which the examples above prove. I.e. CONFIG_SOC_NRF9161_LACA (which is a Kconfig symbol for a SiP), selects CONFIG_SOC_NRF9120. I fail to see how nRF9161 is more "worthy" of being allowed this chain of Kconfig symbols as opposed to Myra, which other than having the STM32G491REI6 MCU in it, also integrates a 128kB FRAM chip, FTDI FT231XQ, crystal oscillators, LDOs etc. See more here: https://designer.antmicro.com/hardware/devices/myra-sip-interposer.

And here's the Kconfig snippet which demonstrates the Kconfig symbol chain: https://github.com/zephyrproject-rtos/zephyr/blob/main/soc/nordic/nrf91/Kconfig.soc#L31-L41.

In summary: this PR doesn't really introduce any new way of defining a SiP; it just chooses the exact same convention that Zephyr had already opted to use.

henrikbrixandersen

adds driver for the mb85rsm1t fram
adds support for a new SoC in Zephyr - Myra SiP
adds a new target that is based on the Myra SiP - Myra SiP Baseboard

This needs to be split into at least two PRs: One for adding the Myra SiP support along with the baseboard, and another for adding the EEPROM driver (unless the EEPROM driver is needed for the board to boot, but it does not look like it is?).

fkokosinski · 2024-10-16T08:14:46Z

but it does not look like it is?

Correct - it's not needed for basic operation of the board. I've removed the driver from this PR.

EEPROM/FRAM driver removed from this PR.

github-actions · 2024-12-22T00:36:38Z

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

kartben · 2024-12-23T04:53:24Z

MAINTAINERS.yml

+    - fkokosinski
+    - kgugala
+    - tgorochowik


2 maintainers should be plenty. Please make whoever is the 3rd name a collaborator

kartben · 2024-12-23T04:55:11Z

boards/antmicro/myra_sip_baseboard/board.yml

@@ -0,0 +1,5 @@
+board:
+  name: myra_sip_baseboard


Suggested change

name: myra_sip_baseboard

name: myra_sip_baseboard

full_name: Myra SiP Baseboard

Added full name

kartben · 2024-12-23T04:55:55Z

boards/antmicro/myra_sip_baseboard/doc/index.rst

+.. _myra_sip_baseboard:
+
+Myra SiP Baseboard
+########################


Suggested change

.. _myra_sip_baseboard:

Myra SiP Baseboard

########################

.. zephyr:board:: myra_sip_baseboard

the new directive is now used in the board doc

kartben · 2024-12-23T04:57:42Z

boards/antmicro/myra_sip_baseboard/doc/index.rst

+.. image:: img/myra_sip_baseboard.webp
+  :align: center
+  :alt: Myra SiP Baseboard
+


Suggested change

.. image:: img/myra_sip_baseboard.webp

:align: center

:alt: Myra SiP Baseboard

zephyr:board:: directive automagically adds the image

kartben · 2024-12-23T04:58:29Z

boards/antmicro/myra_sip_baseboard/doc/index.rst

+Programming and Debugging
+*************************
+
+Applications for the ``myra_sip_baseboard`` board configuration can be built and flashed in the usual way (see :ref:`build_an_application` and :ref:`application_run` for more details).


Suggested change

Applications for the ``myra_sip_baseboard`` board configuration can be built and flashed in the usual way (see :ref:`build_an_application` and :ref:`application_run` for more details).

Applications for the ``myra_sip_baseboard`` board target can be built and flashed in the usual way (see :ref:`build_an_application` and :ref:`application_run` for more details).

kartben · 2024-12-23T04:59:20Z

boards/antmicro/myra_sip_baseboard/myra_sip_baseboard.yaml

+toolchain:
+  - zephyr
+  - gnuarmemb
+  - xtools


Suggested change

- xtools

removed xtools from the list

tejlmand

Approving.

There's currently no clean concepts of SiPs in Zephyr, but HWMV2 has paved the way to improve this by offering a better and more scalable model.
But for now, SiPs are generally exposed as being a SoC.

I think the current suggestion of presenting the Myra SiP with it's own SoC name in the soc / board yaml and Kconfig is acceptable as the system is for now.
I also believe it will make it less intrusive when having a true SiP support, as the names / symbols in that case will not need to change (assumption 🙈 ).

Having dedicated SiP Kconfig symbol selecting the true STM SOC also allows to different cases where it's important to distinguish the SiP from the SoC.

nordicjm · 2025-01-09T10:55:29Z

boards/antmicro/myra_sip_baseboard/myra_sip_baseboard_defconfig

+CONFIG_UART_CONSOLE=y
+CONFIG_ARM_MPU=y
+CONFIG_HW_STACK_PROTECTION=y
+CONFIG_MAIN_STACK_SIZE=4096


why is this needed? (main stack size, not the rest)

nordicjm · 2025-01-09T10:55:45Z

boards/antmicro/myra_sip_baseboard/myra_sip_baseboard_defconfig

+CONFIG_RTC=y
+CONFIG_RTC_STM32=y
+CONFIG_RTC_LOG_LEVEL_WRN=y


why is RTC needed for every single build e.g. hello world?

Add support for the Antmicro's Myra SiP Baseboard. The board uses Antmicro's Myra SiP which integrates STM32G491XX MCU and its SoC configuration. Signed-off-by: Jakub Wasilewski <[email protected]> Signed-off-by: Filip Kokosinski <[email protected]>

This commit adds the `Antmicro platforms` area of maintenance. Signed-off-by: Filip Kokosinski <[email protected]>

fkokosinski force-pushed the 65503-use-myra-sip branch from e792db3 to 351691c Compare October 11, 2024 10:29

nordicjm reviewed Oct 11, 2024

View reviewed changes

nordicjm requested changes Oct 11, 2024

View reviewed changes

fkokosinski force-pushed the 65503-use-myra-sip branch 2 times, most recently from e8db097 to 923636b Compare October 15, 2024 12:28

fkokosinski requested a review from nordicjm October 16, 2024 07:45

fkokosinski marked this pull request as ready for review October 16, 2024 07:45

zephyrbot added area: EEPROM area: Process area: Renode labels Oct 16, 2024

zephyrbot requested review from henrikbrixandersen, mateusz-holenko, MaureenHelm, nashif and stephanosio October 16, 2024 07:46

zephyrbot assigned henrikbrixandersen Oct 16, 2024

henrikbrixandersen previously requested changes Oct 16, 2024

View reviewed changes

fkokosinski force-pushed the 65503-use-myra-sip branch from 923636b to a5687a0 Compare October 16, 2024 08:13

fkokosinski requested a review from henrikbrixandersen October 16, 2024 08:14

henrikbrixandersen removed the area: EEPROM label Oct 16, 2024

henrikbrixandersen removed their assignment Oct 16, 2024

zephyrbot assigned MaureenHelm Oct 16, 2024

fkokosinski mentioned this pull request Oct 16, 2024

drivers: eeprom: add mb85rsm1t fram support #79910

Merged

fkokosinski force-pushed the 65503-use-myra-sip branch from a5687a0 to 0d6ea0b Compare October 16, 2024 10:11

tejlmand self-requested a review October 22, 2024 09:00

github-actions bot added the Stale label Dec 22, 2024

kartben requested changes Dec 23, 2024

View reviewed changes

github-actions bot removed the Stale label Dec 24, 2024

fkokosinski force-pushed the 65503-use-myra-sip branch from 0d6ea0b to ee88950 Compare January 7, 2025 09:06

zephyrbot added the area: Devicetree label Jan 7, 2025

zephyrbot requested review from decsny, galak and rruuaanng January 7, 2025 09:07

fkokosinski force-pushed the 65503-use-myra-sip branch from ee88950 to a40ec6c Compare January 7, 2025 09:47

fkokosinski requested a review from kartben January 7, 2025 11:47

decsny removed their request for review January 7, 2025 15:52

tejlmand previously approved these changes Jan 8, 2025

View reviewed changes

nordicjm reviewed Jan 9, 2025

View reviewed changes

wasilewskiJ and others added 2 commits January 10, 2025 13:39

MAINTAINERS: add the Antmicro platforms area

e2c94fc

This commit adds the `Antmicro platforms` area of maintenance. Signed-off-by: Filip Kokosinski <[email protected]>

fkokosinski dismissed tejlmand’s stale review via e2c94fc January 10, 2025 12:39

fkokosinski force-pushed the 65503-use-myra-sip branch from a40ec6c to e2c94fc Compare January 10, 2025 12:39

nordicjm approved these changes Jan 10, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

boards: add Myra SiP Baseboard #79706

boards: add Myra SiP Baseboard #79706

fkokosinski commented Oct 11, 2024 •

edited by henrikbrixandersen

Loading

nordicjm Oct 11, 2024

fkokosinski Oct 15, 2024

nordicjm Oct 11, 2024

fkokosinski Oct 15, 2024

nordicjm left a comment

kgugala commented Oct 11, 2024 •

edited

Loading

nordicjm commented Oct 11, 2024

fkokosinski commented Oct 14, 2024

henrikbrixandersen left a comment

fkokosinski commented Oct 16, 2024

github-actions bot commented Dec 22, 2024

kartben Dec 23, 2024

fkokosinski Jan 7, 2025

kartben Dec 23, 2024

fkokosinski Jan 7, 2025

kartben Dec 23, 2024

fkokosinski Jan 7, 2025

kartben Dec 23, 2024

fkokosinski Jan 7, 2025

kartben Dec 23, 2024

fkokosinski Jan 7, 2025

kartben Dec 23, 2024

fkokosinski Jan 7, 2025

tejlmand left a comment

nordicjm Jan 9, 2025 •

edited

Loading

nordicjm Jan 9, 2025

	name: myra_sip_baseboard
	name: myra_sip_baseboard
	full_name: Myra SiP Baseboard

	.. image:: img/myra_sip_baseboard.webp
	:align: center
	:alt: Myra SiP Baseboard

	Applications for the ``myra_sip_baseboard`` board configuration can be built and flashed in the usual way (see :ref:`build_an_application` and :ref:`application_run` for more details).
	Applications for the ``myra_sip_baseboard`` board target can be built and flashed in the usual way (see :ref:`build_an_application` and :ref:`application_run` for more details).

boards: add Myra SiP Baseboard #79706

Are you sure you want to change the base?

boards: add Myra SiP Baseboard #79706

Conversation

fkokosinski commented Oct 11, 2024 • edited by henrikbrixandersen Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nordicjm left a comment

Choose a reason for hiding this comment

kgugala commented Oct 11, 2024 • edited Loading

nordicjm commented Oct 11, 2024

fkokosinski commented Oct 14, 2024

henrikbrixandersen left a comment

Choose a reason for hiding this comment

fkokosinski commented Oct 16, 2024

github-actions bot commented Dec 22, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tejlmand left a comment

Choose a reason for hiding this comment

nordicjm Jan 9, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fkokosinski commented Oct 11, 2024 •

edited by henrikbrixandersen

Loading

kgugala commented Oct 11, 2024 •

edited

Loading

nordicjm Jan 9, 2025 •

edited

Loading