intel_adsp: ssp: Add DMA Control Configuration API to Intel SSP DAI Driver #73158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmleman
requested review from
kv2019i,
marcinszkudlinski and
abonislawski
as code owners
tmleman
force-pushed
the
topic/upstream/pr/driver/intel/ssp/dma_constrol
branch
2 times, most recently
from
1a4a32d to
23c6dd6
Compare
2 tasks
softwarecki
previously approved these changes
Jun 5, 2024
pjdobrowolski
previously approved these changes
Jun 11, 2024
marcinszkudlinski
previously approved these changes
Jun 11, 2024
serhiy-katsyuba-intel
previously approved these changes
Jun 11, 2024
kv2019i
requested changes
Jun 13, 2024
tmleman
dismissed stale reviews from serhiy-katsyuba-intel, marcinszkudlinski, pjdobrowolski, and softwarecki
via
932f277
tmleman
force-pushed
the
topic/upstream/pr/driver/intel/ssp/dma_constrol
branch
2 times, most recently
from
932f277 to
bcbf5ee
Compare
tmleman
force-pushed
the
topic/upstream/pr/driver/intel/ssp/dma_constrol
branch
3 times, most recently
from
05ca110 to
c9d5c0b
Compare
kv2019i
previously approved these changes
Jun 17, 2024
tmleman
requested review from
marcinszkudlinski,
pjdobrowolski,
softwarecki and
serhiy-katsyuba-intel
dnikodem
previously approved these changes
Jun 17, 2024
serhiy-katsyuba-intel
previously approved these changes
Jun 17, 2024
This patch introduces a new API function, `dai_config_update`, in the DAI driver API to enable runtime updates to the DAI configuration. This function allows bespoke configuration parameters to be set, enabling updates that are specific to the DAI implementation and can be applied outside of the regular configuration flow. The addition of this API provides greater flexibility for adjusting DAI settings at runtime, which is particularly useful in scenarios where only specific parameters need to be modified without the need to reconfigure the entire DAI interface. Signed-off-by: Tomasz Leman <[email protected]>
Refactor the TLV parsing code from the dai_ssp_parse_aux_data function into a new, separate function called dai_ssp_parse_tlv. This change improves the modularity of the code and allows for the TLV parsing logic to be reused in other contexts where only TLV data needs to be parsed without the entire configuration blob. The new dai_ssp_parse_tlv function takes a pointer to the TLV data and its length as parameters, enabling it to process a buffer containing multiple TLV entries. The original dai_ssp_parse_aux_data function is now simplified to prepare the TLV data and call the new parsing function. Signed-off-by: Tomasz Leman <[email protected]>
pjdobrowolski
previously approved these changes
Jun 18, 2024
tmleman
dismissed stale reviews from pjdobrowolski, serhiy-katsyuba-intel, dnikodem, and kv2019i
via
5d3777a
tmleman
force-pushed
the
topic/upstream/pr/driver/intel/ssp/dma_constrol
branch
from
c9d5c0b to
5d3777a
Compare
|
Small correction, I missed one ID. |
tmleman
requested review from
kv2019i,
dnikodem,
pjdobrowolski and
serhiy-katsyuba-intel
dnikodem
approved these changes
Jun 18, 2024
serhiy-katsyuba-intel
approved these changes
Jun 18, 2024
This commit adds a new API function, `dai_ssp_dma_control_set`, to the Intel SSP DAI driver. This function is designed to set DMA control parameters specifically for the SSP interface. The addition of this API function allows for more granular control of DMA settings, which can be beneficial in scenarios where DMA configuration needs to be modified independently of other DAI settings. Signed-off-by: Tomasz Leman <[email protected]>
kv2019i
approved these changes
Jun 18, 2024
abonislawski
approved these changes
Jul 29, 2024
|
@nashif I think this one can be merged since 3.7 has been released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add DMA Control Configuration API to Intel SSP DAI Driver
This pull request introduces a series of enhancements to the Intel SSP DAI driver in Zephyr, aimed at providing more granular control over DMA settings. The changes include the addition of a new API function for DMA control configuration and a refactoring of the TLV parsing logic for improved modularity and reusability.
Summary of Changes
Commit f1eb040: A new API function
config_updateis introduced to the DAI driver API. This function allows setting DMA control parameters independently from the full DAI configuration blob, offering greater flexibility in DMA behavior configuration.Commit 9d51439: The TLV parsing code is refactored out of the
dai_ssp_parse_aux_datafunction into a new functiondai_ssp_parse_tlv. This standalone function can process multiple TLV entries from a given buffer, simplifying the original function and enhancing code reusability.Commit 5d3777a: The
dai_ssp_dma_control_setAPI function is added to the Intel SSP DAI driver. It enables the setting of DMA control parameters specifically for the SSP interface, allowing for more detailed control of DMA configurations.SOF CI: thesofproject/sof#9156