usb: device_next: add new MIDI 2.0 device class #159914
Annotations
12 errors, 11 warnings, and 3 notices
Run Compliance Tests:
subsys/usb/device_next/class/usbd_midi.c#L25
subsys/usb/device_next/class/usbd_midi.c:25 do not use C99 // comments
|
Run Compliance Tests:
subsys/usb/device_next/class/usbd_midi.c#L32
subsys/usb/device_next/class/usbd_midi.c:32 do not use C99 // comments
|
Run Compliance Tests:
subsys/usb/device_next/class/usbd_midi.c#L37
subsys/usb/device_next/class/usbd_midi.c:37 do not use C99 // comments
|
Run Compliance Tests:
subsys/usb/device_next/class/usbd_midi.c#L42
subsys/usb/device_next/class/usbd_midi.c:42 do not use C99 // comments
|
Run Compliance Tests:
subsys/usb/device_next/class/usbd_midi.c#L54
subsys/usb/device_next/class/usbd_midi.c:54 do not use C99 // comments
|
Run Compliance Tests:
subsys/usb/device_next/class/usbd_midi.c#L65
subsys/usb/device_next/class/usbd_midi.c:65 do not use C99 // comments
|
Run Compliance Tests:
subsys/usb/device_next/class/usbd_midi.c#L74
subsys/usb/device_next/class/usbd_midi.c:74 do not use C99 // comments
|
Run Compliance Tests:
subsys/usb/device_next/class/usbd_midi.c#L82
subsys/usb/device_next/class/usbd_midi.c:82 do not use C99 // comments
|
Run Compliance Tests:
subsys/usb/device_next/class/usbd_midi.c#L97
subsys/usb/device_next/class/usbd_midi.c:97 do not use C99 // comments
|
Run Compliance Tests:
subsys/usb/device_next/class/usbd_midi.c#L103
subsys/usb/device_next/class/usbd_midi.c:103 do not use C99 // comments
|
check-warns:
Checkpatch.txt#L1
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#coding-style for more details.
LINE_SPACING: Missing a blank line after declarations
File:samples/subsys/usb/midi/src/main.c
Line:32
LINE_SPACING: Missing a blank line after declarations
File:samples/subsys/usb/midi/src/main.c
Line:43
LINE_SPACING: Missing a blank line after declarations
File:samples/subsys/usb/midi/src/main.c
Line:59
C99_COMMENTS: do not use C99 // comments
File:subsys/usb/device_next/class/usbd_midi.c
Line:25
C99_COMMENTS: do not use C99 // comments
File:subsys/usb/device_next/class/usbd_midi.c
Line:32
C99_COMMENTS: do not use C99 // comments
File:subsys/usb/device_next/class/usbd_midi.c
Line:37
C99_COMMENTS: do not use C99 // comments
File:subsys/usb/device_next/class/usbd_midi.c
Line:42
C99_COMMENTS: do not use C99 // comments
File:subsys/usb/device_next/class/usbd_midi.c
Line:54
C99_COMMENTS: do not use C99 // comments
File:subsys/usb/device_next/class/usbd_midi.c
Line:65
C99_COMMENTS: do not use C99 // comments
File:subsys/usb/device_next/class/usbd_midi.c
Line:74
C99_COMMENTS: do not use C99 // comments
File:subsys/usb/device_next/class/usbd_midi.c
Line:82
C99_COMMENTS: do not use C99 // comments
File:subsys/usb/device_next/class/usbd_midi.c
Line:97
C99_COMMENTS: do not use C99 // comments
File:subsys/usb/device_next/class/usbd_midi.c
Line:103
C99_COMMENTS: do not use C99 // comments
File:subsys/usb/device_next/class/usbd_midi.c
Line:113
LINE_SPACING: Missing a blank line after declarations
File:subsys/usb/device_next/class/usbd_midi.c
Line:118
LINE_SPACING: Missing a blank line after declarations
File:subsys/usb/device_next/class/usbd_midi.c
Line:120
C99_COMMENTS: do not use C99 // comments
File:subsys/usb/device_next/class/usbd_midi.c
Line:123
C99_COMMENTS: do not use C99 // comments
File:subsys/usb/device_next/class/usbd_midi.c
Line:134
C99_COMMENTS: do not use C99 // comments
File:subsys/usb/device_next/class/usbd_midi.c
Line:142
C99_COMMENTS: do not use C99 // comments
File:subsys/usb/device_next/class/usbd_midi.c
Line:149
C99_COMMENTS: do not use C99 // comments
File:subsys/usb/device_next/class/usbd_midi.c
Line:157
LINE_SPACING: Missing a blank line after declarations
File:subsys/usb/device_next/class/usbd_midi.c
Line:175
LINE_SPACING: Missing a blank line after declarations
File:subsys/usb/device_next/class/usbd_midi.c
Line:184
LINE_SPACING: Missing a blank line after declarations
File:subsys/usb/device_next/class/usbd_midi.c
Line:193
C99_COMMENTS: do not use C99 // comments
File:subsys/usb/device_next/class/usbd_midi.c
Line:197
LINE_SPACING: Missing a blank line after declarations
File:subsys/usb/device_next/class/usbd_midi.c
Line:199
LINE_SPACING: Missing a blank line after declarations
File:subsys/usb/device_next/class/usbd_midi.c
Line:204
LINE_SPACING: Missing a blank line after declarations
File:subsys/usb/device_next/class/usbd_midi.c
Line:207
LINE_SPACING: Missing a blank line after declarations
File:subsys/usb/device_next/class/usbd_midi.c
Line:226
LINE_SPACING: Missing a blank line after declarations
File:subsys/usb/device_next/class/usbd_midi.c
Line:249
LINE_SPACING: Missing a blank line after declarations
File:subsys/usb/device_next/class/usbd_midi.c
Line:269
LINE_SPACING: Missing a blank line after declarations
File:subsys/usb/device_next/class/usbd_midi.c
Line:277
LINE_SPACING: Missing a blank line after declarations
File:subsys/usb/device_next/class/usbd_midi.c
Line:285
LINE_SPACING: Missing a blank line after declarations
File:subsys/usb/device_next/class/usbd_midi.c
Line:293
LINE_SPACING: Missing a blank line after declarations
File:subsys/usb/device_next/class/usbd_midi.c
Line:302
C99_COMMENTS: do not use C99 // comments
File:subsys/usb/device_next/class/usbd_midi.c
Line:310
LINE_SPACING: Missing a blank line after declarations
File:subsys/usb/device_next/class/usbd_midi.c
Line:319
LINE_SPACING: Missing a blank line after declarations
File:subsys/usb/device_next/class/usbd_midi.c
Line:324
LINE_SPACING: Missing a blank line after declarations
File:subsys/usb/device_n
|
check-warns
Process completed with exit code 1.
|
Run Compliance Tests:
samples/subsys/usb/midi/src/main.c#L32
samples/subsys/usb/midi/src/main.c:32 Missing a blank line after declarations
|
Run Compliance Tests:
samples/subsys/usb/midi/src/main.c#L43
samples/subsys/usb/midi/src/main.c:43 Missing a blank line after declarations
|
Run Compliance Tests:
samples/subsys/usb/midi/src/main.c#L59
samples/subsys/usb/midi/src/main.c:59 Missing a blank line after declarations
|
Run Compliance Tests:
subsys/usb/device_next/class/usbd_midi.c#L118
subsys/usb/device_next/class/usbd_midi.c:118 Missing a blank line after declarations
|
Run Compliance Tests:
subsys/usb/device_next/class/usbd_midi.c#L120
subsys/usb/device_next/class/usbd_midi.c:120 Missing a blank line after declarations
|
Run Compliance Tests:
subsys/usb/device_next/class/usbd_midi.c#L175
subsys/usb/device_next/class/usbd_midi.c:175 Missing a blank line after declarations
|
Run Compliance Tests:
subsys/usb/device_next/class/usbd_midi.c#L184
subsys/usb/device_next/class/usbd_midi.c:184 Missing a blank line after declarations
|
Run Compliance Tests:
subsys/usb/device_next/class/usbd_midi.c#L193
subsys/usb/device_next/class/usbd_midi.c:193 Missing a blank line after declarations
|
Run Compliance Tests:
subsys/usb/device_next/class/usbd_midi.c#L199
subsys/usb/device_next/class/usbd_midi.c:199 Missing a blank line after declarations
|
Run Compliance Tests:
subsys/usb/device_next/class/usbd_midi.c#L204
subsys/usb/device_next/class/usbd_midi.c:204 Missing a blank line after declarations
|
check-warns:
ClangFormat.txt#L1
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#clang-format for more details.
You may want to run clang-format on this change:
- return ((uint8_t[16]) {1, 1, 1, 2, 2, 4, 1, 1, 2, 2, 2, 3, 3, 4, 4, 4})[mt & 0x0f];
+ return ((uint8_t[16]){1, 1, 1, 2, 2, 4, 1, 1, 2, 2, 2, 3, 3, 4, 4, 4})[mt & 0x0f];
}
-
File:include/zephyr/usb/class/usb_midi.h
Line:48
You may want to run clang-format on this change:
-#define CS_GR_TRM_BLOCK 0x26
+#define CS_GR_TRM_BLOCK 0x26
File:subsys/usb/device_next/class/usbd_uac2_macros.h
Line:71
You may want to run clang-format on this change:
-#define EP_GENERAL_2_0 0x02
+#define EP_GENERAL_2_0 0x02
File:subsys/usb/device_next/class/usbd_uac2_macros.h
Line:99
|
Run Compliance Tests:
include/zephyr/usb/class/usb_midi.h#L48
include/zephyr/usb/class/usb_midi.h:48
- return ((uint8_t[16]) {1, 1, 1, 2, 2, 4, 1, 1, 2, 2, 2, 3, 3, 4, 4, 4})[mt & 0x0f];
+ return ((uint8_t[16]){1, 1, 1, 2, 2, 4, 1, 1, 2, 2, 2, 3, 3, 4, 4, 4})[mt & 0x0f];
}
-
|
Run Compliance Tests:
subsys/usb/device_next/class/usbd_uac2_macros.h#L71
subsys/usb/device_next/class/usbd_uac2_macros.h:71
-#define CS_GR_TRM_BLOCK 0x26
+#define CS_GR_TRM_BLOCK 0x26
|
Run Compliance Tests:
subsys/usb/device_next/class/usbd_uac2_macros.h#L99
subsys/usb/device_next/class/usbd_uac2_macros.h:99
-#define EP_GENERAL_2_0 0x02
+#define EP_GENERAL_2_0 0x02
|
Loading