Clippy updates #50
Merged
Clippy updates #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theotherjimmy
approved these changes
Jan 17, 2025
Remove the `'static` from const strings, as this causes the clippy warning "redundant_static_lifetimes". Signed-off-by: David Brown <[email protected]>
These are all straightforward source transformations, suggested by clippy, that make the code more idiomatic Rust. Signed-off-by: David Brown <[email protected]>
As we don't have control over the specifics of the bindgen generated code, disable a handful of clippy warnings that it flags. Signed-off-by: David Brown <[email protected]>
Clippy complains about implementing a zero-argument `new` function without also implementing a `Default`. Add these Default implementations to satisfy this. Signed-off-by: David Brown <[email protected]>
As flagged by clippy, add `# Safety` sections to public documentation of functions that are marked as `unsafe`. Signed-off-by: David Brown <[email protected]>
This Mutex type's `lock` method can never fail. Indicate this by making the return value `Infallible`. Signed-off-by: David Brown <[email protected]>
A few updates suggested by clippy to make the code more idiomatic. Signed-off-by: David Brown <[email protected]>
Simple suggestions by clippy to make the code more idiomatic Rust. Signed-off-by: David Brown <[email protected]>
|
Rebased, after #43 merged. |
teburd
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This series (based on top of the rustfmt changes in #43, fixes the suggestions given by running clippy.
Clippy can be run on Zephyr rust code with
env RUSTC_WRAPPER=clippy-driver west build.