Fix the philosopher test for Renode #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d3zd3z
force-pushed
the
phil-timeout
branch
4 times, most recently
from
47140cb to
1523a2b
Compare
Copy the renode installation from the Zephyr CI docker image. This will run these tests in the module before being detected in main. Signed-off-by: David Brown <[email protected]>
The philosopher test seems to run in real time on qemu, and ends up taking just about a minute, the default timeout. Signed-off-by: David Brown <[email protected]>
The renode simulator prints some log message text in front of each debug message, which unfortunately causes the tests to fail. Fix this by adding a "c:" in front of the part we want to match, and removing the anchor from the regex. Signed-off-by: David Brown <[email protected]>
Make sure we test these in the module so failures are detected before it moves to the main repo. Signed-off-by: David Brown <[email protected]>
ithinuel
approved these changes
Oct 28, 2024
teburd
approved these changes
Oct 28, 2024
cfriedt
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to update the Rust code in mainline was causing test failures. The main issue is that this was running renode, and we were not locally. This can cause two problems:
This fix does a few things:
With this, CI should give us a better indicator if the build is likely to work when brought into main.