plugins/ocp: underflow + index fixes for telemetry

Printing the GUID was crashing due to the unsigned int never becoming less than 0, and fixing that triggered a warning about an incorrect max index when printing Event FIFO data. Signed-off-by: Brandon Paupore <[email protected]>
zengqingfu1442 · Jun 19, 2024 · af5f508 · af5f508
1 parent 7a90df9
commit af5f508
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/plugins/ocp/ocp-nvme.c b/plugins/ocp/ocp-nvme.c
@@ -946,7 +946,7 @@ static void print_telemetry_data_area_1(struct telemetry_data_area_1 *da1,
 										int tele_type)
 {
 	if (da1) {
-		unsigned int i = 0;
+		int i = 0;
 		if (tele_type == TELEMETRY_TYPE_HOST)
 			printf("============ Telemetry Host Data area 1 ============\n");
 		else
@@ -974,7 +974,7 @@ static void print_telemetry_data_area_1(struct telemetry_data_area_1 *da1,
 		printf("Data Area 2 Statistic Size         : 0x%x\n", le16_to_cpu(da1->da2_stat_size));
 		for (i = 0; i < 32; i++)
 			printf("reserved5         : 0x%x\n", da1->reserved5[i]);
-		for (i = 0; i < 17; i++){
+		for (i = 0; i < 16; i++) {
 			printf("Event FIFO %d Data Area         : 0x%x\n", i, da1->event_fifo_da[i]);
 			printf("Event FIFO %d Start         : %"PRIu64"\n", i, le64_to_cpu(da1->event_fifo_start[i]));
 			printf("Event FIFO %d Size         : %"PRIu64"\n", i, le64_to_cpu(da1->event_fifo_size[i]));