Skip to content

Commit

Permalink
Makefile: Ignore SC2329
Browse files Browse the repository at this point in the history
In previous versions of shellcheck, SC2317 was emitted for every line of
a unused function and we're ignoring the SC2317 completely:
https://github.com/docker/docker-install/blob/6e61729e66af62fd54c0b659751a431be8f90f68/Makefile#L6

We were ignoring this error due to `version_compare` being reported as a
false positive.

After
koalaman/shellcheck@4f81dbe
this was fixed and now it produces one `SC2329` for the whole function
instead of multiple SC2137.

Signed-off-by: Paweł Gronowski <[email protected]>
  • Loading branch information
vvoland committed May 9, 2024
1 parent dd09dd2 commit 21b3f00
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ VERSION?=
CHANNEL?=

VOLUME_MOUNTS=-v "$(CURDIR)":/v
SHELLCHECK_EXCLUSIONS=$(addprefix -e, SC1091 SC1117 SC2317)
SHELLCHECK_EXCLUSIONS=$(addprefix -e, SC1091 SC1117 SC2317 SC2329)
SHELLCHECK=docker run --rm $(VOLUME_MOUNTS) -w /v koalaman/shellcheck:stable $(SHELLCHECK_EXCLUSIONS)

ENVSUBST_VARS=LOAD_SCRIPT_COMMIT_SHA
Expand Down

0 comments on commit 21b3f00

Please sign in to comment.