Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Towards issue #222. Default autoplay with history tracking to avoid duplicate song plays #230

Closed
wants to merge 1 commit into from

Conversation

cipher1729
Copy link

Provide a general summary of your changes in the Title above.

Important

Mark with [x] to select. Leave as [ ] to unselect.

Motivation and Context

  • Why is this change required? What problem does it solve?
  • If it fixes an open issue, include the text Closes #1 (where 1 would be the issue number) to your commit message.
    Towards issue Autoplay Feature from Youtube #222

Types of changes

What types of changes does your code introduce? Check all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • [x ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

  • Describe your changes in detail.
    I'm using youtube API which returns similar videoID to the current videoID and storing it in a playlist. For the next song, I pick the last entry in the playlist. At the same time, I keep track of all videoIDs played till now in a browser session variable. If this current last entry has already been played, pop one entry from the playlist and get a new probable candidate to play. Repeat.
    Ajax call to get similar videos is made for every song which gets played.
    GUI toggle button needs to be added

Final checklist:

Go over all the following points and check all the boxes that apply
If you're unsure about any of these, don't hesitate to ask. We're here to help!

  • [ x] My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • [ x] I have read the CONTRIBUTING guidelines.
  • [ x] All tests passed.

@cipher1729 cipher1729 closed this Jul 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant