Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove migrations and add changelog for devs #1405

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Chralt98
Copy link
Member

What does it do?

It removes the pallet contracts removal migration and adds a changelog for the developers to inform about the 0.5.7 runtime upgrade change.

What important points should reviewers know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues?

References

@Chralt98 Chralt98 added the s:review-needed The pull request requires reviews label Jan 30, 2025
@Chralt98 Chralt98 self-assigned this Jan 30, 2025
@Chralt98 Chralt98 requested a review from sea212 as a code owner January 30, 2025 13:41
@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.19%. Comparing base (940a8d8) to head (012a110).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1405   +/-   ##
=======================================
  Coverage   93.19%   93.19%           
=======================================
  Files         131      131           
  Lines       29241    29241           
=======================================
  Hits        27252    27252           
  Misses       1989     1989           
Flag Coverage Δ
tests 93.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

robhyrk
robhyrk previously approved these changes Jan 30, 2025
@mergify mergify bot added s:in-progress The pull requests is currently being worked on and removed s:review-needed The pull request requires reviews labels Jan 30, 2025
@Chralt98 Chralt98 added s:accepted This pull request is ready for merge and removed s:in-progress The pull requests is currently being worked on labels Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s:accepted This pull request is ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants