-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use MultiLocation
for tx fee payment instead of u32
#1403
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1403 +/- ##
=======================================
Coverage 93.19% 93.19%
=======================================
Files 131 131
Lines 29241 29241
=======================================
Hits 27252 27252
Misses 1989 1989
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
What does it do?
The asset id of
pallet_asset_tx_payment
is replaced byMultiLocation
fromu32
. This is useful to adapt to the newest polkadot-api and polkadot-extension since their default implementation expects aMultiLocation
.What important points should reviewers know?
pallet_asset_tx_payment
will fail for a transaction in the standalone mode. However, using thetransaction_payment
pallet,ZTG
can still be used in this case.The PR was tested against a local network forked using chopsticks. I could execute transactions using
USDC
from AssetHub as fee payment asset.It is important to know that in case the Polkadot API team doesn't incorporate the suggested PR from us, we could still fix the issue mentioned below by using an override as implemented here.
UPDATE: It is important to use a polkadot API types version that includes this PR, otherwise we would need the override described above. This is the case for a polkadot api version higher than or equal to
15.5.2
.Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues?
polkadot-js/api#5846 (comment)
polkadot-js/api#6074
polkadot-js/api#6081
polkadot-js/api#6083
References