Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect documentation of XcmMetadata::fee_factor #1360

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

maltekliemann
Copy link
Contributor

What does it do?

The documentation incorrectly states that the fee_factor uses the same number of decimals that the foreign asset uses. It actually uses the same number of decimals that every asset uses on Zeitgeist - ten.

What important points should reviewers know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues?

References

@maltekliemann maltekliemann self-assigned this Aug 22, 2024
@maltekliemann maltekliemann added the s:review-needed The pull request requires reviews label Aug 22, 2024
Copy link
Member

@Chralt98 Chralt98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.26%. Comparing base (6868482) to head (9cb9465).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1360   +/-   ##
=======================================
  Coverage   93.26%   93.26%           
=======================================
  Files         133      133           
  Lines       29721    29721           
=======================================
  Hits        27718    27718           
  Misses       2003     2003           
Flag Coverage Δ
tests 93.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@spazcoin
Copy link

Thanks for clearing this up.

@maltekliemann maltekliemann added s:on-hold Work on the pull request has been paused s:accepted This pull request is ready for merge and removed s:on-hold Work on the pull request has been paused s:review-needed The pull request requires reviews labels Aug 23, 2024
@maltekliemann maltekliemann added this to the v0.5.5 milestone Aug 27, 2024
@mergify mergify bot added s:review-needed The pull request requires reviews and removed s:review-needed The pull request requires reviews labels Aug 27, 2024
@mergify mergify bot merged commit ae0afe9 into main Aug 27, 2024
14 checks passed
@mergify mergify bot deleted the mkl-fix-fee-factor-docs branch August 27, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s:accepted This pull request is ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants