Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add highlighting of &ordered attribute #4

Merged
merged 2 commits into from
Jan 24, 2025

Conversation

bbannier
Copy link
Member

No description provided.

@bbannier bbannier requested a review from evantypanski January 24, 2025 15:43
@bbannier bbannier self-assigned this Jan 24, 2025
Copy link

@evantypanski evantypanski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any way &group can be added too? Seems like it's the only other missing attribute

@bbannier
Copy link
Member Author

any way &group can be added too? Seems like it's the only other missing attribute

Definitely, just did that. Part of me wants to just highlight anything starting with & as an attribute, but that would produce slight weirdness if people don't add spaces around their binary operator & uses 🤷.

@bbannier bbannier requested a review from evantypanski January 24, 2025 15:54
Copy link

@evantypanski evantypanski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean it's already weird with something like

event zeek_init() {
    local log = 1;
    local anded = 2&log;
}

but that doesn't really matter much :)

@bbannier bbannier merged commit cfae9b7 into master Jan 24, 2025
1 check passed
@bbannier bbannier deleted the topic/bbannier/highlight-ordered branch January 24, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants