Add prometheus-cpp via ZeekBundle, drop legacy telemetry API
#418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckreibich
force-pushed
the
topic/christian/prometheus-cpp
branch
3 times, most recently
from
d4a3d50 to
5426343
Compare
timwoj
approved these changes
Jul 11, 2024
ckreibich
changed the title
ZeekBundle drop legacy telemetry APIZeekBundle, drop legacy telemetry API
ckreibich
force-pushed
the
topic/christian/prometheus-cpp
branch
from
5426343 to
013a3ed
Compare
This pulls in our new ZeekBundle abstraction to fully build a third-party component into the build tree at configuration time, for subsequent processing via regular add_library. The source location for the bundle is a regular git submodule containing the Zeek project's fork of prometheus-cpp. Co-authored-by: Christian Kreibich <[email protected]>
Add a new function pair `checked` and `checked_deref` to the `internal` namespace that check whether a nullable type (such as `std::shared_ptr`) contains a value before forwarding or using it. Both functions throw an exception with a customizable error message if the check fails. We use the new functions to make sure member variables are initialized using a non-null value or to make sure a registry pointer is valid before dereferencing it.
ckreibich
force-pushed
the
topic/christian/prometheus-cpp
branch
from
013a3ed to
6050f42
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an edit pass over @Neverlord's #402 with one real change: it now always uses the
ZeekBundleapproach to build prometheus-cpp, not just when building stand-alone. I also removed the iterative work onZeekBundle.cmakesince it moved to the cmake repo in the end.