Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move circuit-dependent test utils behind the circuit feature. #453

Merged
merged 5 commits into from
Jan 29, 2025

Conversation

nuttycom
Copy link
Contributor

No description provided.

@daira daira marked this pull request as draft January 28, 2025 21:15
@nuttycom nuttycom force-pushed the circuit_test_deps branch 4 times, most recently from 2353f26 to 7749307 Compare January 29, 2025 01:38
@nuttycom nuttycom marked this pull request as ready for review January 29, 2025 01:48
daira
daira previously approved these changes Jan 29, 2025
Copy link
Contributor

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK. Nit: there's also a clippy beta warning.

@nuttycom
Copy link
Contributor Author

nuttycom commented Jan 29, 2025

force-pushed to address review comments.

Copy link
Contributor

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 11b4b0b

@nuttycom nuttycom merged commit c684e91 into main Jan 29, 2025
29 checks passed
@nuttycom nuttycom deleted the circuit_test_deps branch January 29, 2025 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants