Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add methods for validating aspects of PCZT bundles #443

Merged
merged 3 commits into from
Dec 13, 2024
Merged

Add methods for validating aspects of PCZT bundles #443

merged 3 commits into from
Dec 13, 2024

Conversation

str4d
Copy link
Contributor

@str4d str4d commented Dec 12, 2024

No description provided.

@str4d str4d marked this pull request as ready for review December 13, 2024 00:14
daira
daira reviewed Dec 13, 2024
View reviewed changes
daira
daira previously approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK with suggestion.

nuttycom
nuttycom previously approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@nuttycom nuttycom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 3d951b4 modulo @daira's suggestions

@str4d str4d dismissed stale reviews from nuttycom and daira via 3a5e66f December 13, 2024 07:48
daira
daira approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 9b99350

@daira daira merged commit 1c42667 into main Dec 13, 2024
27 checks passed
@daira daira deleted the pczt-verifier branch December 13, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daira daira daira approved these changes

@nuttycom nuttycom nuttycom left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@str4d @nuttycom @daira