Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zcash_address: Add unified::Item trait to expose opaque typed encoding #1708

Merged
merged 2 commits into from
Feb 20, 2025

Conversation

str4d
Copy link
Contributor

@str4d str4d commented Feb 18, 2025

No description provided.

Copy link

codecov bot commented Feb 18, 2025

Codecov Report

Attention: Patch coverage is 63.63636% with 4 lines in your changes missing coverage. Please review.

Project coverage is 54.16%. Comparing base (7b61fe5) to head (70689cf).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
components/zcash_address/src/kind/unified.rs 63.63% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1708      +/-   ##
==========================================
- Coverage   54.37%   54.16%   -0.21%     
==========================================
  Files         176      176              
  Lines       20385    20466      +81     
==========================================
+ Hits        11084    11086       +2     
- Misses       9301     9380      +79     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

daira
daira previously approved these changes Feb 18, 2025
Copy link
Contributor

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK with non-blocking suggestion.

Copy link
Contributor

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link
Contributor

@nuttycom nuttycom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK fb73395995a276f140de73189d6cb9a255a78368

@nuttycom nuttycom merged commit 2a487d3 into main Feb 20, 2025
34 of 35 checks passed
@str4d str4d deleted the ua-item-typed-encoding branch February 21, 2025 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants