Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1477] Allow Orchard-only UFVK be created from an Orchard FVK #1478

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

pacu
Copy link
Contributor

@pacu pacu commented Jul 31, 2024

closes #1477
closes #1476

Copy link

@conradoplg conradoplg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though if someone tries to implement FROST with Sapling they will need a from_sapling_fvk so it might make sense to just expose new(), but let's wait for ECC input

Copy link
Contributor

@nuttycom nuttycom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, this is an unstable development API addition. Ordinarily we might use a compilation flag for this, but the change is trivial enough that I think it's fine.

Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.82%. Comparing base (7f7b685) to head (22dd30f).
Report is 38 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1478   +/-   ##
=======================================
  Coverage   60.82%   60.82%           
=======================================
  Files         140      140           
  Lines       16472    16472           
=======================================
  Hits        10019    10019           
  Misses       6453     6453           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nuttycom nuttycom merged commit 3b74284 into zcash:main Aug 14, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow Orchard-only UFVK be created from an Orchard FVK Create unstable-frost feature
3 participants