remove detectors upload routine #244
Conversation
rosys/vision/image.py
Outdated
| warn('The tags field is deprecated and will be removed in a future version.', | ||
| DeprecationWarning, stacklevel=2) |
There was a problem hiding this comment.
Nice! I didn't know about warnings.warn. In NiceGUI I created warn_once for this purpose:
https://github.com/zauberzeug/nicegui/blob/3d834e539b4e8f54c96e06b8ee6732bf5960beec/nicegui/helpers.py#L14-L21
But it looks like DeprecationWarnings are hidden by default. Is this ok for us? Or should we simply "forget" to specify the warning type?
There was a problem hiding this comment.
Both ways seem problematic... I would prefer to forget the type and ensure that the warning is shown.
| warn('The tags field is deprecated and will be removed in a future version.', | |
| DeprecationWarning, stacklevel=2) | |
| warn('The tags field is deprecated and will be removed in a future version.', stacklevel=2) | |
There was a problem hiding this comment.
The docs say that it's only ignored if it's not triggered by code in __main__. I tested it in another project that's using RoSys, it won't show up with DeprecationWarning, but without I get a UserWarning.
|
@falkoschindler I will assume you merge this PR whenever you are done with the review |
falkoschindler
deleted the
remove-detectors-upload-mechanism-via-internal-queue
branch
Removes the detectors upload mechanism via internal queue.
This way of uploading images was redundant to the async upload method which is from now on the only way to upload images to the learning loop.