Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sonar reported bug #203

Merged
merged 1 commit into from
Dec 14, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@
};
MessageBus.ProviderSettings.ConsumerConfig(config);

// ToDo: add support for auto commit

Check warning on line 67 in src/SlimMessageBus.Host.Kafka/Consumer/KafkaGroupConsumer.cs

View workflow job for this annotation

GitHub Actions / build

Complete the task associated to this 'TODO' comment. (https://rules.sonarsource.com/csharp/RSPEC-1135)

Check warning on line 67 in src/SlimMessageBus.Host.Kafka/Consumer/KafkaGroupConsumer.cs

View workflow job for this annotation

GitHub Actions / build

Complete the task associated to this 'TODO' comment. (https://rules.sonarsource.com/csharp/RSPEC-1135)
config.EnableAutoCommit = false;
// Notify when we reach EoF, so that we can do a manual commit
config.EnablePartitionEof = true;
Expand Down Expand Up @@ -130,7 +130,7 @@
}
}
catch (OperationCanceledException)
{

Check warning on line 133 in src/SlimMessageBus.Host.Kafka/Consumer/KafkaGroupConsumer.cs

View workflow job for this annotation

GitHub Actions / build

Either remove or fill this block of code. (https://rules.sonarsource.com/csharp/RSPEC-108)

Check warning on line 133 in src/SlimMessageBus.Host.Kafka/Consumer/KafkaGroupConsumer.cs

View workflow job for this annotation

GitHub Actions / build

Either remove or fill this block of code. (https://rules.sonarsource.com/csharp/RSPEC-108)
}

Logger.LogInformation("Group [{Group}]: Unsubscribing from topics", Group);
Expand Down Expand Up @@ -170,7 +170,7 @@
{
_consumerTask = null;

_consumerCts.DisposeSilently();
_consumerCts.Dispose();
_consumerCts = null;
}
}
Expand Down
Loading