Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be robust against cpuinfo failures (Closes: #257) #258

Closed
wants to merge 1 commit into from

Conversation

avalentino
Copy link
Contributor

@avalentino avalentino commented Nov 21, 2020

This PR improves robustness against cpuinfo failures on not supported architectures.

TODO:

  • Unit tests and/or doctests in docstrings
  • tox -e py38 passes locally
  • Docstrings and API docs for any new/modified user-facing classes and functions
  • Changes documented in docs/release.rst
  • tox -e docs passes locally
  • AppVeyor and Travis CI passes
  • Test coverage to 100% (Coveralls passes)

@avalentino
Copy link
Contributor Author

OK, failures on osx seems to be not related to this PR: see Blosc/c-blosc@5fc66f7 and Blosc/c-blosc@406f596.

@joshmoore joshmoore mentioned this pull request Nov 24, 2020
2 tasks
@dstansby
Copy link
Contributor

Since #280 has been merged, which solved #257 I think this PR is now obsolete and can be closed?

@dstansby dstansby closed this Aug 21, 2024
@dstansby
Copy link
Contributor

Thanks for the PR! Since it looks like the original issue is closed, I've closed this, but please do open more PRs if you spot more issues!

@avalentino
Copy link
Contributor Author

Thanks @dstansby

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants