auth tests: Skip site if properties are null #3005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Only two lines were really added, though indenting was changed throughout. |
|
Great job, no security vulnerabilities found in this Pull Request |
thc202
approved these changes
Mar 6, 2025
|
Thank you! |
|
While the commit message matches the code (calling it "site") it's misleading calling the site null, as it's not the site that's null, it's its properties. |
A site might appear to be "null" if it depends on a config.local. Signed-off-by: kingthorin <[email protected]>
kingthorin
force-pushed
the
auth-site-null
branch
from
965af17 to
8dd0106
Compare
kingthorin
changed the title
psiinon
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A site might appear to be "null" if it depends on a config.local.