PDE-5636 feat(cli): include extra fields for analytics

[Natay]

This pull request expands the analytics functionality in the Zapier CLI by updating the way arguments are recorded and adding additional information to the analytics payload.

Changes

• Updated analytics.js:

  • Included app_id in the analytics payload, which is fetched from the linked app configuration OR integrationid" in arguments since some commands ( like "zapier convert" ) won't have a linked app directory when called.

• Updated ZapierBaseCommand.js:

  • Change Object.keys(this.args) to this.args. This allows us to later capture app ID argument value based on the name and populate numArgs and parts of flags . This is not meant to capture this.args in analytics as shown in tests below

Impact

The inclusion of app ID will provide better insights into CLI usage patterns. There is another ticket to track work required for adding "arguments" effectively and safely PDE-5641

Tests

Tested the changes locally

➜  zapier-platform git:(PDE-5636_expand_analyticsBody) ✗ zapier-dev convert 216691 testing5 -v 1.0.0 --debug  
(node:72410) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
(Use `node --trace-deprecation ...` to show where the warning was created)
⠋ Downloading integration from Zapier  zapier:analytics sending {
  command: 'convert',
  isValidCommand: true,
  numArgs: 2,
  app_id: 216691,
  flags: { version: '1.0.0', debug: true },
  cliVersion: '16.0.0',
  os: 'darwin',
  sendUserId: true
} +0ms
⠙ Downloading integration from Zapier  zapier:api >> POST undefined +0ms
  zapier:api >> {"command":"convert","isValidCommand":true,"numArgs":2,"app_id":216691,"flags":{"version":"1.0.0","debug":true},"cliVersion":"16.0.0","os":"darwin"} +1ms
  zapier:api << 200 +0ms
  zapier:api <<  +0ms
  zapier:api ------------ +0ms
  zapier:analytics success: true +122ms
  zapier:api >> GET undefined +16ms
  zapier:api << 200 +0ms
  zapier:api <<  +0ms
  zapier:api ------------ +0ms
⠹ Downloading integration from Zapier  zapier:api >> GET undefined +56ms
  zapier:api << 200 +0ms
  zapier:api <<  +0ms
  zapier:api ------------ +0ms
✔ Downloading integration from Zapier
✔ Writing .env
✔ Writing package.json
✔ Writing .zapierapprc
✔ Writing index.js
✔ Writing authentication.js
✔ Writing triggers/test_key.js
✔ Writing test/triggers/test_key.test.js
✔ Copying /Users/natay/src/github.com/zapier-platform/testing5/.env
✔ Copying /Users/natay/src/github.com/zapier-platform/testing5/.gitignore
✔ Copying /Users/natay/src/github.com/zapier-platform/testing5/.zapierapprc
✔ Copying /Users/natay/src/github.com/zapier-platform/testing5/authentication.js
✔ Copying /Users/natay/src/github.com/zapier-platform/testing5/index.js
✔ Copying /Users/natay/src/github.com/zapier-platform/testing5/package.json
✔ Copying /Users/natay/src/github.com/zapier-platform/testing5/triggers/test_key.js
✔ Copying /Users/natay/src/github.com/zapier-platform/testing5/test/triggers/test_key.test.js

[eliangcs]

I did some quick tests to make sure commands still work. And they do! Approving.

However, while testing, I noticed the debug logs print undefined request URLs.

This may be not related to this PR. But maybe you can fix it along the way? You can fix it by replacing this line:

zapier-platform/packages/cli/src/utils/api.js

Line 98 in a0109d0

debug(`>> ${requestOptions.method} ${requestOptions.url}`);

with:

  debug(`>> ${requestOptions.method} ${requestOptions.url || res.url}`);

[eliangcs]

Nice catch!

[Natay]

Thanks for the review and help testing @eliangcs! Followed your suggestion and fixed the debug log!

[eliangcs]

Thanks for the change! Approved.